[
https://issues.apache.org/jira/browse/KYLIN-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15806444#comment-15806444
]
liyang commented on KYLIN-2337:
-------------------------------
Thanks Kaisen for the drill down!
I minor changed the fix to the below, to still give good debug info in case of
error.
{code}
if (comparator.compare(last, fetched) > 0)
throw new IllegalStateException("Not sorted! last: " + last
+ " fetched: " + fetched);
{code}
> Remove expensive toString in SortedIteratorMergerWithLimit
> ----------------------------------------------------------
>
> Key: KYLIN-2337
> URL: https://issues.apache.org/jira/browse/KYLIN-2337
> Project: Kylin
> Issue Type: Bug
> Components: Query Engine
> Affects Versions: v1.6.0
> Reporter: kangkaisen
> Assignee: kangkaisen
> Attachments: KYLIN-2337.patch, the expensive toString.png
>
>
> The toString in
> {{SortedIteratorMergerWithLimit.MergedIteratorWithLimit.next}} for
> MemoryHungry Measure is expensive and unnecessary.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
