[
https://issues.apache.org/jira/browse/KYLIN-2722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16095395#comment-16095395
]
liyang commented on KYLIN-2722:
-------------------------------
Some quick comments on the patch.
* The package name could be better. It should align with existing measure
packages at least, like {{org.apache.kylin.measure.hllc}}. Maybe
{{org.apache.kylin.measure.reservoir}}?
* The config property has a naming convention [1]. Basically the property
namespace should map to java package. Thus it should be
{{kylin.measure.reservoir.active-default-class}} given above package name is
selected.
[1] http://kylin.apache.org/development/coding_naming_convention.html
> Introduce a new measure, called active reservoir, for actively pushing
> metrics to reporters
> -------------------------------------------------------------------------------------------
>
> Key: KYLIN-2722
> URL: https://issues.apache.org/jira/browse/KYLIN-2722
> Project: Kylin
> Issue Type: Sub-task
> Affects Versions: v2.0.0
> Reporter: Zhong Yanghong
> Assignee: Zhong Yanghong
> Attachments: APACHE-KYLIN-2722.patch
>
>
> For many existing metrics frameworks, they focus on maintaining metrics in
> memory independently for each instance. However, kylin server may consist of
> multiple instances. Thus we extend existing metrics framework by introducing
> *active reservoir* to actively push metrics to reporters which will report
> metrics of its instance to a unified storage.
> Here we introduced two *active reservoirs*. One is called
> {{BlockingReservoir}}, which will buffer the metrics. The other is called
> {{InstantReservoir}}, which owns no buffer and will directly push metrics to
> reporters.
> Generally, one *active reservoir* can push its metrics to multiple reporters
> and one reporter can only listen on one *active reservoir*.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
