[ 
https://issues.apache.org/jira/browse/KYLIN-2745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16095871#comment-16095871
 ] 

Shaofeng SHI commented on KYLIN-2745:
-------------------------------------

I see .settings has been added in gitignore file, so leaving these files in GIT 
doesn't have value. Patch merged in master branch: 
https://github.com/apache/kylin/commit/945e4fd46c3eaa3fc92610e3910e2e726697c25b

Thanks Nirav!

> Remove eclipse .settings directory from each module
> ---------------------------------------------------
>
>                 Key: KYLIN-2745
>                 URL: https://issues.apache.org/jira/browse/KYLIN-2745
>             Project: Kylin
>          Issue Type: Task
>    Affects Versions: Future, v2.0.0
>            Reporter: nirav patel
>            Assignee: nirav patel
>             Fix For: Future
>
>         Attachments: KYLIN-2745.patch
>
>
> I think this directory should not be part of git repo at all. It should be 
> listed in .gitignore file. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to