[
https://issues.apache.org/jira/browse/KYLIN-2612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097341#comment-16097341
]
Shaofeng SHI commented on KYLIN-2612:
-------------------------------------
Fixed it in
https://github.com/apache/kylin/commit/838b047e1201394eeda5e3fcf9dd16cad5e31854
Ted, I didn't see class named "LegacyAclService.java"; I searched the reference
of getFamilyMap method, there is only 1 occurancy, so I assume the
"LegacyAclService.java" might be deleted by someone.
> Potential NPE accessing familyMap in AclTableMigrationTool#getAllAceInfo
> ------------------------------------------------------------------------
>
> Key: KYLIN-2612
> URL: https://issues.apache.org/jira/browse/KYLIN-2612
> Project: Kylin
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Shaofeng SHI
> Priority: Minor
> Labels: newbie, scope
>
> Here is related code:
> {code}
> NavigableMap<byte[], byte[]> familyMap =
> result.getFamilyMap(Bytes.toBytes(AclHBaseStorage.ACL_ACES_FAMILY));
> for (Map.Entry<byte[], byte[]> entry : familyMap.entrySet()) {
> {code}
> Good practice is to check whether familyMap is null / empty first.
> See the following class in hbase for example:
> hbase-client/src/main/java/org/apache/hadoop/hbase/quotas/QuotaTableUtil.java
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
