[ 
https://issues.apache.org/jira/browse/KYLIN-2857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16169300#comment-16169300
 ] 

liyang commented on KYLIN-2857:
-------------------------------

Merged to master. Thanks Zheng Dong!

https://github.com/apache/kylin/commit/21a256075b9be3c3f91ab7126a419eeae866d967

The {{HadoopUtil.getCurrentConfiguration()}} is cached and shared. Must not be 
modified. I made a copy before overwrite job configuration. Also replace 
{{addResource(String)}} with {{addResource(Path)}}, otherwise the XML is not 
read. The review commit:

https://github.com/apache/kylin/commit/e4624779bcf8e3a68b53c77700c9ff695559c76a


> MR configuration should be overwritten by user specified parameters when 
> resuming MR jobs
> -----------------------------------------------------------------------------------------
>
>                 Key: KYLIN-2857
>                 URL: https://issues.apache.org/jira/browse/KYLIN-2857
>             Project: Kylin
>          Issue Type: Improvement
>          Components: Job Engine
>            Reporter: zhengdong
>            Assignee: Dong Li
>              Labels: scope
>         Attachments: 
> 0001-KYLIN-2857-MR-configuration-should-be-overwritten-by.patch, 
> KYLIN-2857-MR-configuration-should-be-overwritten-by.patch
>
>
> For now, MR job conf could be overwritten by kylin_job_conf.xml file, and 
> also further overwritten at project/cube level. 
> Nonetheless, when resuming a MR job after a job server restarting or other 
> kind of interruption, we only use the default conf to trace the job status. 
> That's usually not a problem until user hope to overwrite job status tracing 
> related parameters (job history server address e.g.) to support multi history 
> servers.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to