[jira] [Resolved] (KYLIN-2871) Ineffective null check in SegmentRange

[Dong Li (JIRA)]

     [ 
https://issues.apache.org/jira/browse/KYLIN-2871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dong Li resolved KYLIN-2871.
----------------------------
       Resolution: Fixed
    Fix Version/s: v2.2.0

Thanks Shengping, merged in commit:
https://github.com/apache/kylin/commit/fd4a178cdf5f7c81463938f6909fafb41f54fe9c

> Ineffective null check in SegmentRange
> --------------------------------------
>
>                 Key: KYLIN-2871
>                 URL: https://issues.apache.org/jira/browse/KYLIN-2871
>             Project: Kylin
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Shengping
>            Priority: Minor
>             Fix For: v2.2.0
>
>
> For Endpoint#getComparator() :
> {code}
>                     } else if (b.isMax) {
>                         return a.isMax ? 0 : -1;
>                     } else {
>                         if (a == null || b == null)
>                             throw new IllegalStateException();
> {code}
> The null check should be placed in the front.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)