[
https://issues.apache.org/jira/browse/KYLIN-1892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16213886#comment-16213886
]
Shaofeng SHI edited comment on KYLIN-1892 at 10/21/17 12:47 PM:
----------------------------------------------------------------
Hi Hao,
A couple of comments:
1. kylin.properties is not the perfect place for putting this config; please
add a property on CubeDesc.java, just like the "auto_merge_time_ranges",
"retention_range"; Name like "volatile_range" is better.
2. The web GUI need an input box for this property;
3. Can the volatile range should be calculated from the tail of the segment,
instead of current system time? so that the behavior is consistent with
"retention_range".
4. Unit test is needed. The "testAutoMergeWithGap" in
org.apache.kylin.cube.CubeManagerTest is a reference; You can add new test
method into it.
Could you please refine the patch and then upload a new one? If you're not
familiar with Kylin web, you can leave 2) to us. Thank you hao!
was (Author: shaofengshi):
Hi Hao,
A couple of comments:
1. kylin.properties is not the perfect place for putting this config; please
add a property on CubeDesc.java, just like the "auto_merge_time_ranges",
"retention_range"; Name like "volatile_range" is better.
2. The web GUI need an input box for this property;
3. Unit test is needed. The "testAutoMergeWithGap" in
org.apache.kylin.cube.CubeManagerTest is a reference; You can add new test
method into it.
Could you please refine the patch and then upload a new one? If you're not
familiar with Kylin web, you can leave 2) to us. Thank you hao!
> Support setting a volatile range for auto merge
> -----------------------------------------------
>
> Key: KYLIN-1892
> URL: https://issues.apache.org/jira/browse/KYLIN-1892
> Project: Kylin
> Issue Type: Improvement
> Components: Job Engine
> Affects Versions: v1.5.2
> Reporter: fengYu
> Assignee: Yang Hao
> Attachments: KYLIN-1892.patch
>
>
> We always has some data need to be amended some days later
> in current kylin, once I set Auto Merge Thresholds, the segment newly build
> will merge if reach Thresholds, the next day refresh will refresh merged
> segemnt, which is unnecessary.
> So I want to add a interval configuration means auto merge will merge
> segments outside of the interval.
> for example, if interval = 2, Auto Merge Thresholds=7, if 07-01 to 07-07 is
> built, auto merge will not trigger, when 07-09 built success, auto merge will
> trigger and merge segments from 07-01 to 07-07.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
