[ 
https://issues.apache.org/jira/browse/KYLIN-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Billy Liu resolved KYLIN-2924.
------------------------------
       Resolution: Fixed
         Assignee: Billy Liu
    Fix Version/s: v2.3.0

Thanks [~tedyu], I like this idea very much. Just put the this tool into 
compile job, and make the rule check result as warning by default. We could run 
it for a while, and fix all existing errors before turn the default rules as 
erros. 

The commit id: 
https://github.com/apache/kylin/commit/77b367e40a70a8b1b3cab7f914cb415e86208d27

To turn on the check as error, just remove the line "-XepAllErrorsAsWarnings"


> Utilize error-prone to discover common coding mistakes
> ------------------------------------------------------
>
>                 Key: KYLIN-2924
>                 URL: https://issues.apache.org/jira/browse/KYLIN-2924
>             Project: Kylin
>          Issue Type: Improvement
>            Reporter: Ted Yu
>            Assignee: Billy Liu
>             Fix For: v2.3.0
>
>
> http://errorprone.info/ is a tool which detects common coding mistakes.
> We should incorporate into Kylin build.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to