[
https://issues.apache.org/jira/browse/KYLIN-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
peng.jianhua updated KYLIN-3061:
--------------------------------
Description:
1. Choose one streaming table, choose the 'Streaming Cluster' tab, then click
'Edit' button, refer to [^edit_streaming_table.png]
2. The edit page will be opened, then you can edit the value of topic of 'Kafka
Setting'. As long as you modify the ID, Host, Port value, the original value
tag will follow changes, refer to [^edit_kafka_setting.png];
3. When you click 'cancel' button, you will find the old values have been
changed to the new values, and if you click the 'submit' button, you will also
find the values to be canceled will be submitted, refer to
[^cancel_is_not_right.png]
But I think the correct way should be that 'cancel' button will not change any
value.
I analyze the code and find out the bug of 'streamingConfig.js', the new broker
is the same object as the old broker, we should clone the broker for the new
broker, then it will be ok, so I repair it, please check the patch
[^0001-KYLIN-3061-When-we-cancel-the-Topic-modification-for.patch].
was:
1. Choose one streaming table, choose the 'Streaming Cluster' tab, then click
'Edit' button, refer to [^edit_streaming_table.png]
2. The edit page will be opened, then you can edit the value of topic of 'Kafka
Setting'. As long as you modify the ID, Host, Port value, the original value
tag will follow changes, refer to [^edit_kafka_setting.png];
3. When you click 'cancel' button, you will find the old values have been
changed to the new values, and if you click the 'submit' button, you will also
find the values to be canceled will be submitted, refer to
[^cancel_is_not_right.png]
But I think the correct way should be that 'cancel' button will not change any
value.
I analyze the code and find out the bug of 'streamingConfig.js', the new broker
is the same object as the old broker, we should clone the broker for the new
broker, then it will be ok, so I repair it, please check the patch.
> When we cancel the Topic modification for 'Kafka Setting' of streaming table,
> the 'Cancel' operation will make a mistake.
> -------------------------------------------------------------------------------------------------------------------------
>
> Key: KYLIN-3061
> URL: https://issues.apache.org/jira/browse/KYLIN-3061
> Project: Kylin
> Issue Type: Bug
> Components: Web
> Reporter: peng.jianhua
> Assignee: peng.jianhua
> Labels: patch
> Attachments:
> 0001-KYLIN-3061-When-we-cancel-the-Topic-modification-for.patch,
> cancel_is_not_right.png, edit_kafka_setting.png, edit_streaming_table.png
>
>
> 1. Choose one streaming table, choose the 'Streaming Cluster' tab, then click
> 'Edit' button, refer to [^edit_streaming_table.png]
> 2. The edit page will be opened, then you can edit the value of topic of
> 'Kafka Setting'. As long as you modify the ID, Host, Port value, the original
> value tag will follow changes, refer to [^edit_kafka_setting.png];
> 3. When you click 'cancel' button, you will find the old values have been
> changed to the new values, and if you click the 'submit' button, you will
> also find the values to be canceled will be submitted, refer to
> [^cancel_is_not_right.png]
> But I think the correct way should be that 'cancel' button will not change
> any value.
> I analyze the code and find out the bug of 'streamingConfig.js', the new
> broker is the same object as the old broker, we should clone the broker for
> the new broker, then it will be ok, so I repair it, please check the patch
> [^0001-KYLIN-3061-When-we-cancel-the-Topic-modification-for.patch].
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
