[
https://issues.apache.org/jira/browse/KYLIN-3111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16294038#comment-16294038
]
Dong Li commented on KYLIN-3111:
--------------------------------
Thanks [~Wayne0101] for your contribution!
Two suggestions for this patch:
1. Commit message should follow the same patterns, for example: "KYLIN-3111
XXXXXXXXX". Please refer to other commits and update your message.
2. Your author information(email, name) is not included in this patch. Please
update your git config so that your contribution can be recognized directly.
> Close of Admin instance should be placed in finally block
> ---------------------------------------------------------
>
> Key: KYLIN-3111
> URL: https://issues.apache.org/jira/browse/KYLIN-3111
> Project: Kylin
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Chao Long
> Attachments: KYLIN-3111.patch
>
>
> Looking at the code in DeployCoprocessorCLI.java and
> HtableAlterMetadataCLI.java , I see that close of Admin instance is without
> finally block:
> {code}
> hbaseAdmin.disableTable(table.getTableName());
> table.setValue(metadataKey, metadataValue);
> hbaseAdmin.modifyTable(table.getTableName(), table);
> hbaseAdmin.enableTable(table.getTableName());
> hbaseAdmin.close();
> {code}
> If any exception is thrown in the operations prior to the close(), the
> close() would be skipped, leading to resource leak.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
