[ 
https://issues.apache.org/jira/browse/KYLIN-3114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16297455#comment-16297455
 ] 

Vsevolod Ostapenko commented on KYLIN-3114:
-------------------------------------------

They are completely different things.
kylin.web.query-timeout is used to set "timeout" property on the REST API query 
action of AngularJS QueryService controller 
(https://docs.angularjs.org/api/ngResource/service/$resource). This timeout is 
enforced by AngularJS framework. It's measured in milliseconds. Up to this 
point is was hardcoded to be 300_000 milliseconds (5 minutes).

kylin.query.timeout-seconds - despite its name is not a query timeout at all, 
but a "soft" limit on for how long query results can be fetched from a storage 
provider. It's measured in seconds, and it's enforced in 
SequentialCubeTupleIterator.java (btw, check only happens on the .next() 
iterator call, so technically query may never return and this limit will never 
be enforced).
It defaults to 0 (zero), which indicates that there is no time limit 
(technically it's Integer.MAX_VALUE/1000 seconds).

Just to summarize, those settings are completely different and apply to 
different parts of Kylin. Mine is for the Web UI, and the other one is for the 
Kylin back-end.

> Make timeout for the queries submitted through the Web UI configurable
> ----------------------------------------------------------------------
>
>                 Key: KYLIN-3114
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3114
>             Project: Kylin
>          Issue Type: Bug
>          Components: Web 
>    Affects Versions: v2.2.0
>         Environment: HDP 2.5.6, Kylin 2.2.0
>            Reporter: Vsevolod Ostapenko
>            Assignee: Vsevolod Ostapenko
>            Priority: Minor
>             Fix For: v2.3.0
>
>         Attachments: KYLIN-3114.master.001.patch
>
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> Currently query.js hard codes timeout for the queries submitted via Web UI to 
> be 300_000 milliseconds.
> Depending on the situation, the default value can be either too large, or too 
> small, especially when query does not hit any cube and is passed through to 
> Hive or Impala.
> Query timeout should be made configurable via kylin.properties.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to