[
https://issues.apache.org/jira/browse/KYLIN-3265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16381421#comment-16381421
]
ASF GitHub Bot commented on KYLIN-3265:
---------------------------------------
codecov-io commented on issue #109: KYLIN-3265 Add jobSearchMode as a filter
condition for jobs UI part
URL: https://github.com/apache/kylin/pull/109#issuecomment-369454646
# [Codecov](https://codecov.io/gh/apache/kylin/pull/109?src=pr&el=h1) Report
> Merging [#109](https://codecov.io/gh/apache/kylin/pull/109?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/kylin/commit/76934db8fcddabf437f490e77c8f06c9a4a3db86?src=pr&el=desc)
will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/kylin/pull/109?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #109 +/- ##
============================================
- Coverage 21.47% 21.45% -0.03%
+ Complexity 3822 3817 -5
============================================
Files 992 992
Lines 59742 59742
Branches 8639 8639
============================================
- Hits 12830 12815 -15
- Misses 45732 45747 +15
Partials 1180 1180
```
| [Impacted
Files](https://codecov.io/gh/apache/kylin/pull/109?src=pr&el=tree) | Coverage Δ
| Complexity Δ | |
|---|---|---|---|
|
[...e/kylin/common/KylinConfigCannotInitException.java](https://codecov.io/gh/apache/kylin/pull/109/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Nhbm5vdEluaXRFeGNlcHRpb24uamF2YQ==)
| `0% <0%> (-100%)` | `0% <0%> (-1%)` | |
|
[...main/java/org/apache/kylin/common/KylinConfig.java](https://codecov.io/gh/apache/kylin/pull/109/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZy5qYXZh)
| `30.67% <0%> (-1.69%)` | `20% <0%> (-1%)` | |
|
[.../java/org/apache/kylin/common/KylinConfigBase.java](https://codecov.io/gh/apache/kylin/pull/109/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==)
| `14.98% <0%> (-1.24%)` | `35% <0%> (-2%)` | |
|
[...a/org/apache/kylin/dict/Number2BytesConverter.java](https://codecov.io/gh/apache/kylin/pull/109/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L051bWJlcjJCeXRlc0NvbnZlcnRlci5qYXZh)
| `81.74% <0%> (-0.8%)` | `17% <0%> (-1%)` | |
|
[...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/109/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh)
| `69.6% <0%> (-0.61%)` | `7% <0%> (ø)` | |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/kylin/pull/109?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/kylin/pull/109?src=pr&el=footer). Last
update
[76934db...31cc006](https://codecov.io/gh/apache/kylin/pull/109?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add "jobSearchMode" as a condition to "/kylin/api/jobs" API
> -----------------------------------------------------------
>
> Key: KYLIN-3265
> URL: https://issues.apache.org/jira/browse/KYLIN-3265
> Project: Kylin
> Issue Type: Improvement
> Components: REST Service
> Affects Versions: v2.3.0
> Reporter: Shaofeng SHI
> Priority: Major
> Fix For: v2.3.0
>
> Attachments: KYLIN-3265.master.002.patch,
> KYLIN-3265.master.003.patch, Screen Shot 2018-02-26 at 1.55.21 PM.png
>
>
> In kylin 2.3, the "/kylin/jobs" API will return both cubing job and
> checkpoint job together, this changed the API's behavior as there isn't
> checkpoint job before. We should keep the api only return cubing jobs to be
> compitable as before, and extend the API to add another condition
> 'jobSearchMode' to determine which kind of job should be returned.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
