[ 
https://issues.apache.org/jira/browse/KYLIN-3236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16383361#comment-16383361
 ] 

ASF GitHub Bot commented on KYLIN-3236:
---------------------------------------

xingpeng1 opened a new pull request #110: KYLIN-3236
URL: https://github.com/apache/kylin/pull/110
 
 
    KYLIN-3236 The function 'reGenerateAdvancedDict()' has an error logical 
judgment, which will cause an exception when you edit the cube.
   
   Signed-off-by: xingpeng1 <xing.pe...@zte.com.cn>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> The function 'reGenerateAdvancedDict()' has an error logical judgment, which 
> will cause an exception when you edit the cube.
> ----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: KYLIN-3236
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3236
>             Project: Kylin
>          Issue Type: Bug
>          Components: Web 
>    Affects Versions: v2.3.0
>            Reporter: Peng Xing
>            Assignee: Peng Xing
>            Priority: Major
>              Labels: patch
>         Attachments: 
> 0001-KYLIN-3236-The-function-reGenerateAdvancedDict-has-a.patch, 1.PNG, 
> 2.PNG, 3.PNG
>
>
> # When remove deprecated distinct measures, the code has an error logical 
> judgment In function 'reGenerateAdvancedDict()', as follows:
> {code:java}
>     //remove deprecated distinct measures
>     angular.forEach($scope.cubeMetaFrame.dictionaries, function (dict, index) 
> {
>       if (distinctMeasures.indexOf(dict.column) === -1 && 
> reuseColumns.indexOf(dict.column) === -1) {
>         $scope.cubeMetaFrame.dictionaries.splice(index, 1);
>       }
>     });
> {code}
> This will result in accidental deletion of advanced dictionaries.
>  Please review the patch, thanks!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to