[
https://issues.apache.org/jira/browse/KYLIN-3287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16395171#comment-16395171
]
ASF GitHub Bot commented on KYLIN-3287:
---------------------------------------
codecov-io commented on issue #114: KYLIN-3287, fix when a shard by column is
in dict encoding, dict buil…
URL: https://github.com/apache/kylin/pull/114#issuecomment-372295252
# [Codecov](https://codecov.io/gh/apache/kylin/pull/114?src=pr&el=h1) Report
> Merging [#114](https://codecov.io/gh/apache/kylin/pull/114?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/kylin/commit/06f497eb603134a6b0ddbfd88739ccaddab007fb?src=pr&el=desc)
will **decrease** coverage by `0.02%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/kylin/pull/114?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #114 +/- ##
============================================
- Coverage 21.86% 21.84% -0.03%
+ Complexity 3887 3886 -1
============================================
Files 996 996
Lines 59992 59992
Branches 8665 8665
============================================
- Hits 13119 13106 -13
- Misses 45653 45665 +12
- Partials 1220 1221 +1
```
| [Impacted
Files](https://codecov.io/gh/apache/kylin/pull/114?src=pr&el=tree) | Coverage Δ
| Complexity Δ | |
|---|---|---|---|
|
[...che/kylin/engine/mr/steps/CreateDictionaryJob.java](https://codecov.io/gh/apache/kylin/pull/114/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvc3RlcHMvQ3JlYXRlRGljdGlvbmFyeUpvYi5qYXZh)
| `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
|
[...org/apache/kylin/rest/util/QueryRequestLimits.java](https://codecov.io/gh/apache/kylin/pull/114/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvdXRpbC9RdWVyeVJlcXVlc3RMaW1pdHMuamF2YQ==)
| `35.71% <0%> (-4.77%)` | `5% <0%> (-1%)` | |
|
[...rg/apache/kylin/storage/hbase/HBaseConnection.java](https://codecov.io/gh/apache/kylin/pull/114/diff?src=pr&el=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS9IQmFzZUNvbm5lY3Rpb24uamF2YQ==)
| `13.08% <0%> (-4.72%)` | `6% <0%> (ø)` | |
|
[...g/apache/kylin/metadata/cachesync/Broadcaster.java](https://codecov.io/gh/apache/kylin/pull/114/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvY2FjaGVzeW5jL0Jyb2FkY2FzdGVyLmphdmE=)
| `54.22% <0%> (-1.5%)` | `21% <0%> (ø)` | |
|
[.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/114/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=)
| `64.56% <0%> (-0.79%)` | `0% <0%> (ø)` | |
|
[...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/114/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh)
| `70.21% <0%> (+0.6%)` | `7% <0%> (ø)` | :arrow_down: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/kylin/pull/114?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/kylin/pull/114?src=pr&el=footer). Last
update
[06f497e...f26969c](https://codecov.io/gh/apache/kylin/pull/114?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> When a shard by column is in dict encoding, dict building error.
> ----------------------------------------------------------------
>
> Key: KYLIN-3287
> URL: https://issues.apache.org/jira/browse/KYLIN-3287
> Project: Kylin
> Issue Type: Bug
> Reporter: jiatao.tao
> Assignee: jiatao.tao
> Priority: Major
> Attachments: image-2018-03-12-14-14-50-112.png,
> image-2018-03-12-14-14-59-193.png, image-2018-03-12-14-15-42-046.png,
> image-2018-03-12-14-16-38-657.png, image-2018-03-12-14-17-46-780.png
>
>
> In dict encoding.
> !image-2018-03-12-14-14-50-112.png|width=544,height=84!
> !image-2018-03-12-14-14-59-193.png|width=535,height=631!
> In int encoding
> !image-2018-03-12-14-15-42-046.png|width=544,height=87!
> !image-2018-03-12-14-16-38-657.png!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)