[ https://issues.apache.org/jira/browse/KYLIN-3071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16465781#comment-16465781 ]
Shaofeng SHI commented on KYLIN-3071: ------------------------------------- [~liyang.g...@gmail.com] Growing Dict will base on the biggest dict to build a new dictionary (when there is new value not covered). The drawback is, a small segment may uses a very big dictionary. Hao's change is, if there is an existing dictionary contains all the values, then use it. It won't make the dictionary bigger. > Add config to reuse dict to reduce dict size > --------------------------------------------- > > Key: KYLIN-3071 > URL: https://issues.apache.org/jira/browse/KYLIN-3071 > Project: Kylin > Issue Type: Improvement > Components: Metadata > Reporter: Yang Hao > Assignee: Yang Hao > Priority: Major > Fix For: Future > > Attachments: KYLIN-3071.apache-master.001.patch > > > When calling DictionaryManager.trySaveNewDict, and growing dict is not > enabled, it only use the history dict which is equal, it may generate many > dict. We should supply a config to use contains instead of equal to reuse old > dict. -- This message was sent by Atlassian JIRA (v7.6.3#76005)