[
https://issues.apache.org/jira/browse/KYLIN-3295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16495338#comment-16495338
]
ASF GitHub Bot commented on KYLIN-3295:
---------------------------------------
yiming187 commented on issue #145: KYLIN-3295, clean unused class:SQLDigestUtil
URL: https://github.com/apache/kylin/pull/145#issuecomment-393212364
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Unused method SQLDigestUtil#appendTsFilterToExecute
> ---------------------------------------------------
>
> Key: KYLIN-3295
> URL: https://issues.apache.org/jira/browse/KYLIN-3295
> Project: Kylin
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: jiatao.tao
> Priority: Minor
> Fix For: v2.4.0
>
>
> SQLDigestUtil#appendTsFilterToExecute is not called anywhere.
> {code}
> T ret = action.apply(null);
> {code}
> Passing null to {{apply}} seems incorrect.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
