[
https://issues.apache.org/jira/browse/KYLIN-3161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16499269#comment-16499269
]
ASF GitHub Bot commented on KYLIN-3161:
---------------------------------------
codecov-io commented on issue #147: KYLIN-3161 Enforce global dictionary for
bitmap count distinct column…
URL: https://github.com/apache/kylin/pull/147#issuecomment-394130240
# [Codecov](https://codecov.io/gh/apache/kylin/pull/147?src=pr&el=h1) Report
> Merging [#147](https://codecov.io/gh/apache/kylin/pull/147?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/kylin/commit/8205fac0eb9c7c986e7690166793c5cc08742cd6?src=pr&el=desc)
will **increase** coverage by `0.03%`.
> The diff coverage is `88.88%`.
[](https://codecov.io/gh/apache/kylin/pull/147?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #147 +/- ##
============================================
+ Coverage 22.1% 22.14% +0.03%
- Complexity 4007 4014 +7
============================================
Files 1011 1011
Lines 61100 61114 +14
Branches 8752 8756 +4
============================================
+ Hits 13508 13534 +26
+ Misses 46349 46342 -7
+ Partials 1243 1238 -5
```
| [Impacted
Files](https://codecov.io/gh/apache/kylin/pull/147?src=pr&el=tree) | Coverage Δ
| Complexity Δ | |
|---|---|---|---|
|
[...lin/cube/model/validation/rule/DictionaryRule.java](https://codecov.io/gh/apache/kylin/pull/147/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL3ZhbGlkYXRpb24vcnVsZS9EaWN0aW9uYXJ5UnVsZS5qYXZh)
| `91.83% <88.88%> (+0.4%)` | `21 <0> (+6)` | :arrow_up: |
|
[.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/147/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=)
| `63.84% <0%> (-2.31%)` | `0% <0%> (ø)` | |
|
[...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/147/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh)
| `70.21% <0%> (+4.25%)` | `7% <0%> (ø)` | :arrow_down: |
|
[...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/147/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==)
| `78.37% <0%> (+5.4%)` | `6% <0%> (+1%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/kylin/pull/147?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/kylin/pull/147?src=pr&el=footer). Last
update
[8205fac...d023324](https://codecov.io/gh/apache/kylin/pull/147?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Enforce global dictionary for bitmap count distinct column
> ----------------------------------------------------------
>
> Key: KYLIN-3161
> URL: https://issues.apache.org/jira/browse/KYLIN-3161
> Project: Kylin
> Issue Type: Improvement
> Components: Measure - Count Distinct
> Reporter: Shaofeng SHI
> Priority: Major
>
> For bitmap based count distinct column (as the data type is not int), a
> Global dictionary is required. But now user can use normal dictionary, which
> may cause incorrect result.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
