[ 
https://issues.apache.org/jira/browse/KYLIN-3379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16569707#comment-16569707
 ] 

ASF GitHub Bot commented on KYLIN-3379:
---------------------------------------

tttMelody commented on issue #188: KYLIN-3379 fix ts add bug and enhance the 
test coverage of timestamp add.
URL: https://github.com/apache/kylin/pull/188#issuecomment-410583317
 
 
   Hi @shaofengshi, CI passed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> timestampadd test coverage is not enough
> ----------------------------------------
>
>                 Key: KYLIN-3379
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3379
>             Project: Kylin
>          Issue Type: Bug
>    Affects Versions: v2.3.1
>            Reporter: hongbin ma
>            Assignee: hongbin ma
>            Priority: Major
>
> complex cases like 
> timestampadd(MONTH,23,test_kylin_fact.cal_dt) or 
> timestampadd(MONTH,-23,test_kylin_fact.cal_dt) is not covered. 
>  
> And my tests shows this kind of queries will fail IT. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to