[
https://issues.apache.org/jira/browse/KYLIN-3497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16579576#comment-16579576
]
ASF GitHub Bot commented on KYLIN-3497:
---------------------------------------
codecov-io commented on issue #199: KYLIN-3497 Make JDBC Module more testable
URL: https://github.com/apache/kylin/pull/199#issuecomment-412819042
# [Codecov](https://codecov.io/gh/apache/kylin/pull/199?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base
(`master@ddfed27`). [Click here to learn what that
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `76.92%`.
[](https://codecov.io/gh/apache/kylin/pull/199?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #199 +/- ##
=========================================
Coverage ? 21.45%
Complexity ? 4357
=========================================
Files ? 1069
Lines ? 67824
Branches ? 9836
=========================================
Hits ? 14553
Misses ? 51889
Partials ? 1382
```
| [Impacted
Files](https://codecov.io/gh/apache/kylin/pull/199?src=pr&el=tree) | Coverage Δ
| Complexity Δ | |
|---|---|---|---|
|
[...main/java/org/apache/kylin/jdbc/IRemoteClient.java](https://codecov.io/gh/apache/kylin/pull/199/diff?src=pr&el=tree#diff-amRiYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vamRiYy9JUmVtb3RlQ2xpZW50LmphdmE=)
| `100% <ø> (ø)` | `0 <0> (?)` | |
|
[...n/java/org/apache/kylin/jdbc/KylinJdbcFactory.java](https://codecov.io/gh/apache/kylin/pull/199/diff?src=pr&el=tree#diff-amRiYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vamRiYy9LeWxpbkpkYmNGYWN0b3J5LmphdmE=)
| `72.22% <ø> (ø)` | `7 <0> (?)` | |
|
[...ain/java/org/apache/kylin/jdbc/KylinResultSet.java](https://codecov.io/gh/apache/kylin/pull/199/diff?src=pr&el=tree#diff-amRiYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vamRiYy9LeWxpblJlc3VsdFNldC5qYXZh)
| `86.95% <100%> (ø)` | `5 <0> (?)` | |
|
[...in/java/org/apache/kylin/jdbc/KylinConnection.java](https://codecov.io/gh/apache/kylin/pull/199/diff?src=pr&el=tree#diff-amRiYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vamRiYy9LeWxpbkNvbm5lY3Rpb24uamF2YQ==)
| `73.91% <50%> (ø)` | `12 <2> (?)` | |
|
[...c/main/java/org/apache/kylin/jdbc/KylinClient.java](https://codecov.io/gh/apache/kylin/pull/199/diff?src=pr&el=tree#diff-amRiYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vamRiYy9LeWxpbkNsaWVudC5qYXZh)
| `67.67% <80%> (ø)` | `33 <8> (?)` | |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/kylin/pull/199?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/kylin/pull/199?src=pr&el=footer). Last
update
[ddfed27...c23a8c0](https://codecov.io/gh/apache/kylin/pull/199?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Make JDBC Module more testable
> ------------------------------
>
> Key: KYLIN-3497
> URL: https://issues.apache.org/jira/browse/KYLIN-3497
> Project: Kylin
> Issue Type: Improvement
> Components: Driver - JDBC
> Reporter: Ian Hu
> Assignee: Ian Hu
> Priority: Minor
>
> While I am trying my work about KYLIN-3496, I found it is difficult to test.
> I would offer a work to make it more testable.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
