[
https://issues.apache.org/jira/browse/KYLIN-3588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16626900#comment-16626900
]
ASF GitHub Bot commented on KYLIN-3588:
---------------------------------------
coveralls commented on issue #248: KYLIN-3588, fix potentially duplicate
putting in RemoveBlackoutRealiz…
URL: https://github.com/apache/kylin/pull/248#issuecomment-424232479
## Pull Request Test Coverage Report for [Build
3644](https://coveralls.io/builds/19171706)
* **0** of **8** **(0.0%)** changed or added relevant lines in **1** file
are covered.
* **1** unchanged line in **1** file lost coverage.
* Overall coverage increased (+**0.002%**) to **23.125%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
|
[query/src/main/java/org/apache/kylin/query/routing/rules/RemoveBlackoutRealizationsRule.java](https://coveralls.io/builds/19171706/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Frouting%2Frules%2FRemoveBlackoutRealizationsRule.java#L61)
| 0 | 8 | 0.0%
<!-- | **Total:** | **0** | **8** | **0.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
|
[query/src/main/java/org/apache/kylin/query/routing/rules/RemoveBlackoutRealizationsRule.java](https://coveralls.io/builds/19171706/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Frouting%2Frules%2FRemoveBlackoutRealizationsRule.java#L72)
| 1 | 0.0% |
<!-- | **Total:** | **1** | | -->
| Totals | [](https://coveralls.io/builds/19171706)
|
| :-- | --: |
| Change from base [Build 3641](https://coveralls.io/builds/19170293): |
0.002% |
| Covered Lines: | 16160 |
| Relevant Lines: | 69880 |
---
##### đź’› - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Potentially duplicate put to RemoveBlackoutRealizationsRule#filters map
> -----------------------------------------------------------------------
>
> Key: KYLIN-3588
> URL: https://issues.apache.org/jira/browse/KYLIN-3588
> Project: Kylin
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: jiatao.tao
> Priority: Minor
>
> Here is related code:
> {code}
> IRealizationFilter filter = filters.get(conf);
> if (filter == null) {
> try {
> Class<? extends IRealizationFilter> clz =
> ClassUtil.forName(conf.getQueryRealizationFilter(), IRealizationFilter.class);
> filter =
> clz.getConstructor(KylinConfig.class).newInstance(conf);
> } catch (Exception e) {
> throw new RuntimeException(e);
> }
> filters.put(conf, filter);
> {code}
> Two threads may find out there is no filter for conf, they would proceed with
> creation of IRealizationFilter instances and try to put into the map.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
