[ 
https://issues.apache.org/jira/browse/KYLIN-3581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16626918#comment-16626918
 ] 

ASF GitHub Bot commented on KYLIN-3581:
---------------------------------------

coveralls commented on issue #249: KYLIN-3581 Obey the contract of 'x.equals(y) 
should be consistent with x.compareTo(y)'
URL: https://github.com/apache/kylin/pull/249#issuecomment-424236234
 
 
   ## Pull Request Test Coverage Report for [Build 
3645](https://coveralls.io/builds/19171883)
   
   * **0** of **10**   **(0.0%)**  changed or added relevant lines in **2** 
files are covered.
   * **3** unchanged lines in **2** files lost coverage.
   * Overall coverage decreased (**-0.008%**) to **23.116%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | 
[core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/DoggedCubeBuilder.java](https://coveralls.io/builds/19171883/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FDoggedCubeBuilder.java#L353)
 | 0 | 5 | 0.0%
   | 
[core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/InMemCubeBuilder.java](https://coveralls.io/builds/19171883/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FInMemCubeBuilder.java#L528)
 | 0 | 5 | 0.0%
   <!-- | **Total:** | **0** | **10** | **0.0%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | 
[core-metadata/src/main/java/org/apache/kylin/metadata/cachesync/Broadcaster.java](https://coveralls.io/builds/19171883/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Fcachesync%2FBroadcaster.java#L149)
 | 1 | 57.71% |
   | 
[core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://coveralls.io/builds/19171883/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2FTreeCuboidScheduler.java#L124)
 | 2 | 68.46% |
   <!-- | **Total:** | **3** |  | -->
   
   |  Totals | [![Coverage 
Status](https://coveralls.io/builds/19171883/badge)](https://coveralls.io/builds/19171883)
 |
   | :-- | --: |
   | Change from base [Build 3641](https://coveralls.io/builds/19170293): |  
-0.008% |
   | Covered Lines: | 16155 |
   | Relevant Lines: | 69888 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> compareTo method should be paired with equals method
> ----------------------------------------------------
>
>                 Key: KYLIN-3581
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3581
>             Project: Kylin
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: XiaoXiang Yu
>            Priority: Minor
>             Fix For: v2.4.2, v2.5.1
>
>
> DoggedCubeBuilder$MergeSlot and InMemCubeBuilder$CuboidTask define compareTo 
> method.
> They should define equals method as well.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to