[
https://issues.apache.org/jira/browse/KYLIN-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16627677#comment-16627677
]
ASF GitHub Bot commented on KYLIN-3587:
---------------------------------------
coveralls commented on issue #256: KYLIN-3587 Including tableID in
IllegalStateException messages
URL: https://github.com/apache/kylin/pull/256#issuecomment-424429996
## Pull Request Test Coverage Report for [Build
3656](https://coveralls.io/builds/19181941)
* **0** of **3** **(0.0%)** changed or added relevant lines in **1** file
are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage increased (+**0.003%**) to **23.125%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
|
[core-metadata/src/main/java/org/apache/kylin/metadata/project/ProjectManager.java](https://coveralls.io/builds/19181941/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Fproject%2FProjectManager.java#L306)
| 0 | 3 | 0.0%
<!-- | **Total:** | **0** | **3** | **0.0%** | -->
| Totals | [](https://coveralls.io/builds/19181941)
|
| :-- | --: |
| Change from base [Build 3650](https://coveralls.io/builds/19173507): |
0.003% |
| Covered Lines: | 16159 |
| Relevant Lines: | 69878 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Null value is used in IllegalStateException message
> ---------------------------------------------------
>
> Key: KYLIN-3587
> URL: https://issues.apache.org/jira/browse/KYLIN-3587
> Project: Kylin
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Yichen Zhou
> Priority: Minor
>
> In ProjectManager :
> {code}
> TableDesc table = metaMgr.getTableDesc(tableId, projectName);
> if (table == null) {
> throw new IllegalStateException("Cannot find table '" +
> table + "' in metadata manager");
> {code}
> Since table is null, the exception message is not helpful.
> It seems including tableId in the message is better.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
