[
https://issues.apache.org/jira/browse/KYLIN-3356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16628624#comment-16628624
]
ASF GitHub Bot commented on KYLIN-3356:
---------------------------------------
shaofengshi closed pull request #258: KYLIN-3356 Constant in SecretKeySpec
URL: https://github.com/apache/kylin/pull/258
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/core-common/src/main/java/org/apache/kylin/common/util/EncryptUtil.java
b/core-common/src/main/java/org/apache/kylin/common/util/EncryptUtil.java
index deb54d4749..191b3cd06a 100644
--- a/core-common/src/main/java/org/apache/kylin/common/util/EncryptUtil.java
+++ b/core-common/src/main/java/org/apache/kylin/common/util/EncryptUtil.java
@@ -19,6 +19,8 @@
package org.apache.kylin.common.util;
import java.nio.charset.StandardCharsets;
+import java.security.SecureRandom;
+
import org.apache.commons.codec.binary.Base64;
import javax.crypto.Cipher;
@@ -28,8 +30,10 @@
/**
* thisIsAsecretKey
*/
- private static byte[] key = { 0x74, 0x68, 0x69, 0x73, 0x49, 0x73, 0x41,
0x53, 0x65, 0x63, 0x72, 0x65, 0x74, 0x4b,
- 0x65, 0x79 };
+ private static byte[] key = new byte[16];
+ {
+ new SecureRandom().nextBytes(key);
+ }
public static String encrypt(String strToEncrypt) {
try {
diff --git
a/core-common/src/test/java/org/apache/kylin/common/util/EncryptUtilTest.java
b/core-common/src/test/java/org/apache/kylin/common/util/EncryptUtilTest.java
index bc1c3e7ae4..717a94afed 100644
---
a/core-common/src/test/java/org/apache/kylin/common/util/EncryptUtilTest.java
+++
b/core-common/src/test/java/org/apache/kylin/common/util/EncryptUtilTest.java
@@ -27,7 +27,14 @@
public void testAESEncrypt(){
String input = "hello world";
String result = EncryptUtil.encrypt(input);
- Assert.assertEquals("4stv/RRleOtvie/8SLHmXA==", result);
+ Assert.assertEquals("dImt2pa7nDD7STLgdzFXGg==", result);
+ }
+
+ @Test
+ public void testAESDecrypt(){
+ String input = "F2nAgzbBcGRs8wtObIaXfQ==";
+ String result = EncryptUtil.decrypt(input);
+ Assert.assertEquals("wordcount", result);
}
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Constant in SecretKeySpec
> -------------------------
>
> Key: KYLIN-3356
> URL: https://issues.apache.org/jira/browse/KYLIN-3356
> Project: Kylin
> Issue Type: Improvement
> Reporter: liyang
> Priority: Minor
> Fix For: v2.6.0
>
>
> Reported by Rumen Paletov <[email protected]>:
> As part of some research about the common crypto mistakes that developers
> make <[https://cs.ucsb.edu/~chris/research/doc/ccs13_cryptolint.pdf]>, I
> noticed that your application has one of them.
>
> In particular, there's a violation of Rule 3 in
> org.apache.kylin.common.util.EncryptUtil
>
> <[https://github.com/apache/kylin/blob/5552164ba09eba989b9ddccdf3f1e4f83ed0b799/core-common/src/main/java/org/apache/kylin/common/util/EncryptUtil.java#L36]>.
> That is, SecretKeySpec is being initialized with a constant key
>
> <[https://github.com/apache/kylin/blob/5552164ba09eba989b9ddccdf3f1e4f83ed0b799/core-common/src/main/java/org/apache/kylin/common/util/EncryptUtil.java#L30]>
> instead of a randomly generated one.
>
> One solution would be to generate a key using SecureRandom:
>
> > byte[] key = new byte[16];
> > new SecureRandom.nextBytes(key);
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
