[jira] [Commented] (KYLIN-3574) Unclosed lookup table in DictionaryGeneratorCLI#processSegment

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/KYLIN-3574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16629805#comment-16629805
 ] 

ASF GitHub Bot commented on KYLIN-3574:
---------------------------------------

codecov-io commented on issue #246: KYLIN-3574 Close underlying resource of 
lookup table
URL: https://github.com/apache/kylin/pull/246#issuecomment-424971704
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/246?src=pr&el=h1) Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@dcd2a63`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/kylin/pull/246/graphs/tree.svg?width=650&token=JawVgbgsVo&height=150&src=pr)](https://codecov.io/gh/apache/kylin/pull/246?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master     #246   +/-   ##
   =========================================
     Coverage          ?   21.16%           
     Complexity        ?     4405           
   =========================================
     Files             ?     1086           
     Lines             ?    69724           
     Branches          ?    10090           
   =========================================
     Hits              ?    14755           
     Misses            ?    53568           
     Partials          ?     1401
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/kylin/pull/246?src=pr&el=tree) | Coverage Δ 
| Complexity Δ | |
   |---|---|---|---|
   | 
[.../apache/kylin/cube/cli/DictionaryGeneratorCLI.java](https://codecov.io/gh/apache/kylin/pull/246/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2NsaS9EaWN0aW9uYXJ5R2VuZXJhdG9yQ0xJLmphdmE=)
 | `0% <0%> (ø)` | `0 <0> (?)` | |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/kylin/pull/246?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/kylin/pull/246?src=pr&el=footer). Last 
update 
[dcd2a63...ab4b07e](https://codecov.io/gh/apache/kylin/pull/246?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Unclosed lookup table in DictionaryGeneratorCLI#processSegment
> --------------------------------------------------------------
>
>                 Key: KYLIN-3574
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3574
>             Project: Kylin
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: XiaoXiang Yu
>            Priority: Minor
>             Fix For: v2.4.2, v2.5.1
>
>
> Here is related code:
> {code}
>                 JoinDesc join = 
> cubeSeg.getModel().getJoinsTree().getJoinByPKSide(lookup);
>                 cubeMgr.getLookupTable(cubeSeg, join);
> {code}
> The returned lookup table should be closed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)