[
https://issues.apache.org/jira/browse/KYLIN-3600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16630394#comment-16630394
]
ASF GitHub Bot commented on KYLIN-3600:
---------------------------------------
yiming187 commented on issue #266: KYLIN-3600 Add private constructor for
utility classes.
URL: https://github.com/apache/kylin/pull/266#issuecomment-425087434
LGTM. Merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Utility classes should not have public constructors
> ---------------------------------------------------
>
> Key: KYLIN-3600
> URL: https://issues.apache.org/jira/browse/KYLIN-3600
> Project: Kylin
> Issue Type: Bug
> Reporter: Lijun Cao
> Assignee: Lijun Cao
> Priority: Major
> Fix For: v2.6.0
>
>
> Utility classes, which are collections of static members, are not meant to be
> instantiated. Even abstract utility classes, which can be extended, should
> not have public constructors.
> Most utility classes are located in
> *core-common/src/main/java/org/apache/kylin/common/util*
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
