[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues

Fri, 28 Sep 2018 00:13:55 -0700 


    [ 
https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16631459#comment-16631459
 ] 

ASF GitHub Bot commented on KYLIN-3597:
---------------------------------------

codecov-io commented on issue #262: KYLIN-3597 Improve code smell
URL: https://github.com/apache/kylin/pull/262#issuecomment-425344030
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/262?src=pr&el=h1) Report
   > Merging [#262](https://codecov.io/gh/apache/kylin/pull/262?src=pr&el=desc) 
into 
[master](https://codecov.io/gh/apache/kylin/commit/8e7d2a90fa8488e6720130c511d139296939b32d?src=pr&el=desc)
 will **increase** coverage by `0.01%`.
   > The diff coverage is `5.71%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/kylin/pull/262/graphs/tree.svg?width=650&token=JawVgbgsVo&height=150&src=pr)](https://codecov.io/gh/apache/kylin/pull/262?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #262      +/-   ##
   ============================================
   + Coverage     21.15%   21.16%   +0.01%     
   - Complexity     4405     4407       +2     
   ============================================
     Files          1086     1086              
     Lines         69743    69745       +2     
     Branches      10088    10088              
   ============================================
   + Hits          14757    14765       +8     
   + Misses        53586    53584       -2     
   + Partials       1400     1396       -4
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/kylin/pull/262?src=pr&el=tree) | Coverage Δ 
| Complexity Δ | |
   |---|---|---|---|
   | 
[...apache/kylin/storage/hbase/util/RowCounterCLI.java](https://codecov.io/gh/apache/kylin/pull/262/diff?src=pr&el=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS91dGlsL1Jvd0NvdW50ZXJDTEkuamF2YQ==)
 | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | 
[...e/kylin/source/kafka/util/KafkaSampleProducer.java](https://codecov.io/gh/apache/kylin/pull/262/diff?src=pr&el=tree#diff-c291cmNlLWthZmthL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9zb3VyY2Uva2Fma2EvdXRpbC9LYWZrYVNhbXBsZVByb2R1Y2VyLmphdmE=)
 | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | 
[...lin/storage/gtrecord/SegmentCubeTupleIterator.java](https://codecov.io/gh/apache/kylin/pull/262/diff?src=pr&el=tree#diff-Y29yZS1zdG9yYWdlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9zdG9yYWdlL2d0cmVjb3JkL1NlZ21lbnRDdWJlVHVwbGVJdGVyYXRvci5qYXZh)
 | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | 
[...n/source/kafka/config/KafkaConsumerProperties.java](https://codecov.io/gh/apache/kylin/pull/262/diff?src=pr&el=tree#diff-c291cmNlLWthZmthL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9zb3VyY2Uva2Fma2EvY29uZmlnL0thZmthQ29uc3VtZXJQcm9wZXJ0aWVzLmphdmE=)
 | `62.85% <33.33%> (ø)` | `12 <0> (ø)` | :arrow_down: |
   | 
[...lin/dict/lookup/cache/RocksDBLookupTableCache.java](https://codecov.io/gh/apache/kylin/pull/262/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGVDYWNoZS5qYXZh)
 | `76.68% <0%> (+0.51%)` | `27% <0%> (ø)` | :arrow_down: |
   | 
[.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/262/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=)
 | `66.15% <0%> (+2.3%)` | `0% <0%> (ø)` | :arrow_down: |
   | 
[...org/apache/kylin/rest/util/QueryRequestLimits.java](https://codecov.io/gh/apache/kylin/pull/262/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvdXRpbC9RdWVyeVJlcXVlc3RMaW1pdHMuamF2YQ==)
 | `40.47% <0%> (+4.76%)` | `6% <0%> (+1%)` | :arrow_up: |
   | 
[...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/262/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==)
 | `78.37% <0%> (+5.4%)` | `6% <0%> (+1%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/kylin/pull/262?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/kylin/pull/262?src=pr&el=footer). Last 
update 
[8e7d2a9...25bf7c8](https://codecov.io/gh/apache/kylin/pull/262?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix sonar reported static code issues
> -------------------------------------
>
>                 Key: KYLIN-3597
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3597
>             Project: Kylin
>          Issue Type: Improvement
>          Components: Others
>            Reporter: Shaofeng SHI
>            Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to