[
https://issues.apache.org/jira/browse/KYLIN-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16632037#comment-16632037
]
ASF GitHub Bot commented on KYLIN-2924:
---------------------------------------
coveralls commented on issue #270: KYLIN-2924 enable google error-prone in
compile phase
URL: https://github.com/apache/kylin/pull/270#issuecomment-425479277
## Pull Request Test Coverage Report for [Build
3705](https://coveralls.io/builds/19249459)
* **1** of **12** **(8.33%)** changed or added relevant lines in **8**
files are covered.
* **79** unchanged lines in **26** files lost coverage.
* Overall coverage decreased (**-0.02%**) to **23.152%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
|
[core-common/src/main/java/org/apache/kylin/common/util/SparkEntry.java](https://coveralls.io/builds/19249459/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Futil%2FSparkEntry.java#L35)
| 0 | 1 | 0.0%
|
[core-cube/src/main/java/org/apache/kylin/cube/model/DimensionDesc.java](https://coveralls.io/builds/19249459/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fmodel%2FDimensionDesc.java#L173)
| 0 | 1 | 0.0%
|
[core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java](https://coveralls.io/builds/19249459/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fimpl%2Fthreadpool%2FDefaultScheduler.java#L54)
| 0 | 1 | 0.0%
|
[server-base/src/main/java/org/apache/kylin/rest/controller/ProjectController.java](https://coveralls.io/builds/19249459/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fcontroller%2FProjectController.java#L134)
| 0 | 1 | 0.0%
|
[server-base/src/main/java/org/apache/kylin/rest/controller/ModelController.java](https://coveralls.io/builds/19249459/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fcontroller%2FModelController.java#L120)
| 0 | 1 | 0.0%
|
[core-metrics/src/main/java/org/apache/kylin/metrics/lib/impl/InstantReservoir.java](https://coveralls.io/builds/19249459/source?filename=core-metrics%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetrics%2Flib%2Fimpl%2FInstantReservoir.java#L53)
| 0 | 2 | 0.0%
|
[server-base/src/main/java/org/apache/kylin/rest/util/AclPermissionUtil.java](https://coveralls.io/builds/19249459/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Futil%2FAclPermissionUtil.java#L38)
| 0 | 4 | 0.0%
<!-- | **Total:** | **1** | **12** | **8.33%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
|
[server-base/src/main/java/org/apache/kylin/rest/util/QueryRequestLimits.java](https://coveralls.io/builds/19249459/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Futil%2FQueryRequestLimits.java#L72)
| 1 | 47.62% |
|
[server-base/src/main/java/org/apache/kylin/rest/util/AclPermissionUtil.java](https://coveralls.io/builds/19249459/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Futil%2FAclPermissionUtil.java#L43)
| 1 | 0.0% |
|
[server-base/src/main/java/org/apache/kylin/rest/security/springacl/AclRecord.java](https://coveralls.io/builds/19249459/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fsecurity%2Fspringacl%2FAclRecord.java#L180)
| 1 | 0.0% |
|
[storage-hbase/src/main/java/org/apache/kylin/storage/hbase/cube/v2/coprocessor/endpoint/CubeVisitService.java](https://coveralls.io/builds/19249459/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Fcube%2Fv2%2Fcoprocessor%2Fendpoint%2FCubeVisitService.java#L367)
| 1 | 0.0% |
|
[core-storage/src/main/java/org/apache/kylin/storage/gtrecord/GTCubeStorageQueryBase.java](https://coveralls.io/builds/19249459/source?filename=core-storage%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fgtrecord%2FGTCubeStorageQueryBase.java#L157)
| 1 | 0.0% |
|
[core-metadata/src/main/java/org/apache/kylin/metadata/filter/CompareTupleFilter.java](https://coveralls.io/builds/19249459/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Ffilter%2FCompareTupleFilter.java#L308)
| 1 | 34.0% |
|
[tool/src/main/java/org/apache/kylin/tool/MetadataCleanupJob.java](https://coveralls.io/builds/19249459/source?filename=tool%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Ftool%2FMetadataCleanupJob.java#L61)
| 1 | 0.0% |
|
[core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java](https://coveralls.io/builds/19249459/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fimpl%2Fthreadpool%2FDefaultScheduler.java#L184)
| 1 | 73.33% |
|
[atopcalcite/src/main/java/org/apache/calcite/sql/type/SqlTypeUtil.java](https://coveralls.io/builds/19249459/source?filename=atopcalcite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fcalcite%2Fsql%2Ftype%2FSqlTypeUtil.java#L1313)
| 1 | 0.0% |
|
[atopcalcite/src/main/java/org/apache/calcite/runtime/SqlFunctions.java](https://coveralls.io/builds/19249459/source?filename=atopcalcite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fcalcite%2Fruntime%2FSqlFunctions.java#L1690)
| 1 | 3.05% |
<!-- | **Total:** | **79** | | -->
| Totals | [](https://coveralls.io/builds/19249459)
|
| :-- | --: |
| Change from base [Build 3703](https://coveralls.io/builds/19245700): |
-0.02% |
| Covered Lines: | 16161 |
| Relevant Lines: | 69805 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Utilize error-prone to discover common coding mistakes
> ------------------------------------------------------
>
> Key: KYLIN-2924
> URL: https://issues.apache.org/jira/browse/KYLIN-2924
> Project: Kylin
> Issue Type: Improvement
> Reporter: Ted Yu
> Assignee: Billy Liu
> Priority: Major
> Fix For: v2.6.0
>
>
> http://errorprone.info/ is a tool which detects common coding mistakes.
> We should incorporate into Kylin build.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
