[jira] [Commented] (KYLIN-3603) HBase connection isn't closed in UpdateHTableHostCLI

Fri, 28 Sep 2018 19:41:43 -0700 


    [ 
https://issues.apache.org/jira/browse/KYLIN-3603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16632742#comment-16632742
 ] 

ASF GitHub Bot commented on KYLIN-3603:
---------------------------------------

codecov-io edited a comment on issue #271: KYLIN-3603 Close the HBase 
connection after used in UpdateHTableHostCLI
URL: https://github.com/apache/kylin/pull/271#issuecomment-425606722
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/271?src=pr&el=h1) Report
   > Merging [#271](https://codecov.io/gh/apache/kylin/pull/271?src=pr&el=desc) 
into 
[master](https://codecov.io/gh/apache/kylin/commit/65ab55e920a611c12a331f084599bbca6e3381bc?src=pr&el=desc)
 will **not change** coverage.
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/kylin/pull/271/graphs/tree.svg?width=650&token=JawVgbgsVo&height=150&src=pr)](https://codecov.io/gh/apache/kylin/pull/271?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master     #271   +/-   ##
   =========================================
     Coverage     21.15%   21.15%           
     Complexity     4406     4406           
   =========================================
     Files          1086     1086           
     Lines         69745    69745           
     Branches      10088    10088           
   =========================================
     Hits          14758    14758           
     Misses        53588    53588           
     Partials       1399     1399
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/kylin/pull/271?src=pr&el=tree) | Coverage Δ 
| Complexity Δ | |
   |---|---|---|---|
   | 
[.../kylin/storage/hbase/util/UpdateHTableHostCLI.java](https://codecov.io/gh/apache/kylin/pull/271/diff?src=pr&el=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS91dGlsL1VwZGF0ZUhUYWJsZUhvc3RDTEkuamF2YQ==)
 | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | 
[...org/apache/kylin/rest/util/QueryRequestLimits.java](https://codecov.io/gh/apache/kylin/pull/271/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvdXRpbC9RdWVyeVJlcXVlc3RMaW1pdHMuamF2YQ==)
 | `35.71% <0%> (-4.77%)` | `5% <0%> (-1%)` | |
   | 
[.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/271/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=)
 | `63.84% <0%> (-2.31%)` | `0% <0%> (ø)` | |
   | 
[...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/271/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh)
 | `70.21% <0%> (+0.91%)` | `7% <0%> (ø)` | :arrow_down: |
   | 
[...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/271/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==)
 | `78.37% <0%> (+5.4%)` | `6% <0%> (+1%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/kylin/pull/271?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/kylin/pull/271?src=pr&el=footer). Last 
update 
[65ab55e...8cdd103](https://codecov.io/gh/apache/kylin/pull/271?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> HBase connection isn't closed in UpdateHTableHostCLI
> ----------------------------------------------------
>
>                 Key: KYLIN-3603
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3603
>             Project: Kylin
>          Issue Type: Bug
>            Reporter: Lijun Cao
>            Assignee: Lijun Cao
>            Priority: Minor
>             Fix For: v2.6.0
>
>
> The HBase connection is only used in the constructor to get an *_Admin_* , it 
> should be closed after used.
> {code:java}
> public UpdateHTableHostCLI(List<String> htables, String oldHostValue) throws 
> IOException {
>         this.htables = htables;
>         this.oldHostValue = oldHostValue;
>         Connection conn = 
> ConnectionFactory.createConnection(HBaseConfiguration.create());
>         hbaseAdmin = conn.getAdmin();
>         this.kylinConfig = KylinConfig.getInstanceFromEnv();
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to