[
https://issues.apache.org/jira/browse/KYLIN-3617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16649405#comment-16649405
]
ASF GitHub Bot commented on KYLIN-3617:
---------------------------------------
nichunen commented on a change in pull request #286: KYLIN-3617 Use job's cache
in job scheduler
URL: https://github.com/apache/kylin/pull/286#discussion_r224993945
##########
File path: core-job/src/main/java/org/apache/kylin/job/dao/ExecutableDao.java
##########
@@ -391,4 +405,13 @@ public void deleteJobOutput(String uuid) throws
PersistentException {
throw new PersistentException(e);
}
}
+
+ public void reloadAll() throws IOException {
+ try (AutoReadWriteLock.AutoLock lock =
executableDigestMapLock.lockForWrite()) {
+ executableDigestCrud.reloadAll();
Review comment:
@shaofengshi You are right, it's a mistake, should use lockForWrite during
reloading. PR updated, thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Reduce number of visiting metastore for job scheduler
> -----------------------------------------------------
>
> Key: KYLIN-3617
> URL: https://issues.apache.org/jira/browse/KYLIN-3617
> Project: Kylin
> Issue Type: Improvement
> Components: Job Engine
> Affects Versions: v2.4.1
> Reporter: nichunen
> Assignee: nichunen
> Priority: Major
> Fix For: v2.6.0
>
>
> For KYLIN-3470 introduced cache for jobs' metadata, it's also can be used in
> job scheduler to reduce the pressure on metastore
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
