shaofengshi commented on a change in pull request #290: KYLIN-3632 Add 
configuration that can switch on/off preparedStatement cache
URL: https://github.com/apache/kylin/pull/290#discussion_r225475004
 
 

 ##########
 File path: 
core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java
 ##########
 @@ -1457,6 +1457,10 @@ public int getQueryMaxCacheStatementInstancePerKey() {
         return 
Integer.parseInt(this.getOptional("kylin.query.statement-cache-max-num-per-key",
 String.valueOf(50)));
     }
 
+    public boolean isQueryPreparedStatementCacheEnable() {
+        return 
Boolean.parseBoolean(this.getOptional("kylin.query.statement-cache-enabled", 
"false"));
 
 Review comment:
   Gang, can we enable it by default? It is a good feature.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to