[
https://issues.apache.org/jira/browse/KYLIN-3632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16653006#comment-16653006
]
ASF GitHub Bot commented on KYLIN-3632:
---------------------------------------
codecov-io edited a comment on issue #290: KYLIN-3632 Add configuration that
can switch on/off preparedStatement cache
URL: https://github.com/apache/kylin/pull/290#issuecomment-429717664
# [Codecov](https://codecov.io/gh/apache/kylin/pull/290?src=pr&el=h1) Report
> Merging [#290](https://codecov.io/gh/apache/kylin/pull/290?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/kylin/commit/5f6007ff2b5aead4781c876fa3203dd67188d90b?src=pr&el=desc)
will **decrease** coverage by `<.01%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/kylin/pull/290?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #290 +/- ##
===========================================
- Coverage 21.3% 21.3% -0.01%
Complexity 4444 4444
===========================================
Files 1087 1087
Lines 69983 69984 +1
Branches 10109 10109
===========================================
Hits 14907 14907
- Misses 53672 53675 +3
+ Partials 1404 1402 -2
```
| [Impacted
Files](https://codecov.io/gh/apache/kylin/pull/290?src=pr&el=tree) | Coverage Δ
| Complexity Δ | |
|---|---|---|---|
|
[...va/org/apache/kylin/rest/service/QueryService.java](https://codecov.io/gh/apache/kylin/pull/290/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VydmljZS9RdWVyeVNlcnZpY2UuamF2YQ==)
| `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
|
[.../java/org/apache/kylin/common/KylinConfigBase.java](https://codecov.io/gh/apache/kylin/pull/290/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==)
| `14.66% <0%> (-0.03%)` | `36 <0> (ø)` | |
|
[...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/290/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh)
| `70.21% <0%> (-0.61%)` | `7% <0%> (ø)` | |
|
[...g/apache/kylin/source/datagen/ColumnGenerator.java](https://codecov.io/gh/apache/kylin/pull/290/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc291cmNlL2RhdGFnZW4vQ29sdW1uR2VuZXJhdG9yLmphdmE=)
| `72.29% <0%> (+1.35%)` | `8% <0%> (ø)` | :arrow_down: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/kylin/pull/290?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/kylin/pull/290?src=pr&el=footer). Last
update
[5f6007f...41e3300](https://codecov.io/gh/apache/kylin/pull/290?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add configuration that can switch on/off preparedStatement cache in Kylin
> server
> --------------------------------------------------------------------------------
>
> Key: KYLIN-3632
> URL: https://issues.apache.org/jira/browse/KYLIN-3632
> Project: Kylin
> Issue Type: Improvement
> Components: Query Engine
> Reporter: Ma Gang
> Assignee: Ma Gang
> Priority: Minor
> Fix For: v2.5.1
>
>
> From Kylin 2.5 we introduce preparedStatement cache feature, it can be turn
> on/off for each request by adding a new field "enableStatementCache" in the
> query request, by default it is on. We need to add a switch in server level,
> the preparedStatement cache can take effective only when the switch is on, by
> default, it will be set to false.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
