codecov-io commented on issue #292: KYLIN-3634 when filter column has null value may cause incorrect query result URL: https://github.com/apache/kylin/pull/292#issuecomment-430509449 # [Codecov](https://codecov.io/gh/apache/kylin/pull/292?src=pr&el=h1) Report > Merging [#292](https://codecov.io/gh/apache/kylin/pull/292?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/5f6007ff2b5aead4781c876fa3203dd67188d90b?src=pr&el=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/kylin/pull/292?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #292 +/- ## ============================================ - Coverage 21.3% 21.29% -0.01% Complexity 4444 4444 ============================================ Files 1087 1087 Lines 69983 69986 +3 Branches 10109 10109 ============================================ Hits 14907 14907 - Misses 53672 53677 +5 + Partials 1404 1402 -2 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/292?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...c/main/java/org/apache/kylin/gridtable/GTUtil.java](https://codecov.io/gh/apache/kylin/pull/292/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9ncmlkdGFibGUvR1RVdGlsLmphdmE=) | `1.35% <0%> (-0.03%)` | `2 <0> (ø)` | | | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/292/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `70.21% <0%> (-0.61%)` | `7% <0%> (ø)` | | | [...g/apache/kylin/source/datagen/ColumnGenerator.java](https://codecov.io/gh/apache/kylin/pull/292/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc291cmNlL2RhdGFnZW4vQ29sdW1uR2VuZXJhdG9yLmphdmE=) | `72.29% <0%> (+1.35%)` | `8% <0%> (ø)` | :arrow_down: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/292?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/292?src=pr&el=footer). Last update [5f6007f...33181a7](https://codecov.io/gh/apache/kylin/pull/292?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
