[
https://issues.apache.org/jira/browse/KYLIN-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16660627#comment-16660627
]
ASF GitHub Bot commented on KYLIN-3633:
---------------------------------------
coveralls edited a comment on issue #301: KYLIN-3633 Avoid potential dead lock
when building global dictionary
URL: https://github.com/apache/kylin/pull/301#issuecomment-431662392
## Pull Request Test Coverage Report for [Build
3797](https://coveralls.io/builds/19669769)
* **6** of **20** **(30.0%)** changed or added relevant lines in **3**
files are covered.
* **3** unchanged lines in **1** file lost coverage.
* Overall coverage increased (+**0.004%**) to **23.333%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
|
[core-dictionary/src/main/java/org/apache/kylin/dict/global/SegmentAppendTrieDictBuilder.java](https://coveralls.io/builds/19669769/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Fglobal%2FSegmentAppendTrieDictBuilder.java#L85)
| 0 | 1 | 0.0%
|
[core-dictionary/src/main/java/org/apache/kylin/dict/GlobalDictionaryBuilder.java](https://coveralls.io/builds/19669769/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2FGlobalDictionaryBuilder.java#L109)
| 0 | 3 | 0.0%
|
[core-dictionary/src/main/java/org/apache/kylin/dict/DictionaryGenerator.java](https://coveralls.io/builds/19669769/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2FDictionaryGenerator.java#L87)
| 6 | 16 | 37.5%
<!-- | **Total:** | **6** | **20** | **30.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
|
[core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/19669769/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L449)
| 3 | 78.42% |
<!-- | **Total:** | **3** | | -->
| Totals | [](https://coveralls.io/builds/19669769)
|
| :-- | --: |
| Change from base [Build 3795](https://coveralls.io/builds/19664534): |
0.004% |
| Covered Lines: | 16332 |
| Relevant Lines: | 69996 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Dead lock may happen in building global dictionary
> --------------------------------------------------
>
> Key: KYLIN-3633
> URL: https://issues.apache.org/jira/browse/KYLIN-3633
> Project: Kylin
> Issue Type: Bug
> Components: Measure - Count Distinct
> Affects Versions: v2.4.1
> Reporter: nichunen
> Assignee: nichunen
> Priority: Major
> Fix For: v2.5.1
>
>
> During the building of global dict, if an error happens, the builder's lock
> maybe un-released. This will block all other building jobs with global dict.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
