luguosheng1314 closed pull request #310: KYLIN-3646 Add instruction about
rowkey sequence in "Advanced setting" page
URL: https://github.com/apache/kylin/pull/310
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/webapp/app/partials/cubeDesigner/advanced_settings.html
b/webapp/app/partials/cubeDesigner/advanced_settings.html
index 963d472ef9..89229d039c 100755
--- a/webapp/app/partials/cubeDesigner/advanced_settings.html
+++ b/webapp/app/partials/cubeDesigner/advanced_settings.html
@@ -198,10 +198,12 @@ <h3 style="margin-left:42px;">Aggregation Groups </h3>
</div>
<div class="form-group large-popover" >
<h3 style="margin-left:42px">Rowkeys <i kylinpopover
placement="right" title="Rowkey" template="rowkeyTip.html" class="fa
fa-info-circle"></i></h3>
-
+ <div style="padding: 0 42px; word-break: normal;">
+ <b>Important: </b>Dimension's positioin on HBase rowkey is
critical for performance. You can drag and drop to adjust the sequence. In
short, put filtering dimension before non-filtering dimension, and put high
cardinality dimension before low cardinality dimension.
+ </div>
<div style="margin-left:42px">
<div class="box-body">
- <table style="margin-left:42px; width:92%;position:relative"
+ <table style="width:92%;position:relative"
ng-if="cubeMetaFrame.rowkey.rowkey_columns.length > 0"
class="table table-hover table-bordered list">
<thead>
@@ -303,7 +305,7 @@ <h3 style="margin-left:42px">Mandatory Cuboids</h3>
<div style="margin-left:42px;">
<div class="box-body">
<!-- view mode-->
- <table ng-if="cubeMetaFrame.mandatory_dimension_set_list.length
> 0 && state.mode!=='edit'" class="table table-hover table-bordered list"
style="table-layout: fixed;margin-left:42px;width:92%;">
+ <table ng-if="cubeMetaFrame.mandatory_dimension_set_list.length
> 0 && state.mode!=='edit'" class="table table-hover table-bordered list"
style="table-layout: fixed;width:92%;">
<thead>
<tr>
<th>Cuboids</th>
@@ -318,7 +320,7 @@ <h3 style="margin-left:42px">Mandatory Cuboids</h3>
</tbody>
</table>
<!-- edit mode-->
- <table ng-if="state.mode=='edit'" class="table table-hover
table-bordered list" style="table-layout: fixed;margin-left:42px;width:92%;">
+ <table ng-if="state.mode=='edit'" class="table table-hover
table-bordered list" style="table-layout: fixed;width:92%;">
<thead>
<tr>
<th>Cuboids</th>
@@ -509,7 +511,7 @@ <h3 style="margin-left:42px;margin-bottom:30px;">Advanced
Snapshot Table <i kyl
<div style="margin-left:42px">
<!-- edit mode-->
<div ng-if="state.mode=='edit'" class="box-body">
- <table class="table table-hover table-bordered list"
style="table-layout: fixed;margin-left:42px;width:92%;">
+ <table class="table table-hover table-bordered list"
style="table-layout: fixed;width:92%;">
<thead>
<tr>
<th style="width:60%">Snapshot Table</th>
@@ -571,7 +573,7 @@ <h3 style="margin-left:42px;margin-bottom:30px;">Advanced
Snapshot Table <i kyl
</div>
<!-- view-->
<div ng-if="state.mode=='view'" class="box-body">
- <table class="table table-hover table-bordered list"
style="table-layout: fixed;margin-left:42px;width:92%;">
+ <table class="table table-hover table-bordered list"
style="table-layout: fixed;width:92%;">
<thead>
<tr>
<th style="width:60%">Snapshot Table</th>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
