[
https://issues.apache.org/jira/browse/KYLIN-3552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16663109#comment-16663109
]
ASF GitHub Bot commented on KYLIN-3552:
---------------------------------------
codecov-io commented on issue #312: KYLIN-3552 Data Source SDK to ingest data
from different JDBC sources
URL: https://github.com/apache/kylin/pull/312#issuecomment-432892290
# [Codecov](https://codecov.io/gh/apache/kylin/pull/312?src=pr&el=h1) Report
> Merging [#312](https://codecov.io/gh/apache/kylin/pull/312?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/kylin/commit/21bc42d90a0fb392115b4eda75a11cf092f5c7e6?src=pr&el=desc)
will **increase** coverage by `0.63%`.
> The diff coverage is `55.85%`.
[](https://codecov.io/gh/apache/kylin/pull/312?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #312 +/- ##
============================================
+ Coverage 21.31% 21.94% +0.63%
- Complexity 4447 4689 +242
============================================
Files 1090 1123 +33
Lines 70022 71347 +1325
Branches 10102 10287 +185
============================================
+ Hits 14925 15659 +734
- Misses 53695 54191 +496
- Partials 1402 1497 +95
```
| [Impacted
Files](https://codecov.io/gh/apache/kylin/pull/312?src=pr&el=tree) | Coverage Δ
| Complexity Δ | |
|---|---|---|---|
|
[...java/org/apache/kylin/source/jdbc/JdbcDialect.java](https://codecov.io/gh/apache/kylin/pull/312/diff?src=pr&el=tree#diff-c291cmNlLWpkYmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9qZGJjL0pkYmNEaWFsZWN0LmphdmE=)
| `0% <ø> (ø)` | `0 <0> (?)` | |
|
[...in/source/jdbc/metadata/SQLServerJdbcMetadata.java](https://codecov.io/gh/apache/kylin/pull/312/diff?src=pr&el=tree#diff-c291cmNlLWpkYmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9qZGJjL21ldGFkYXRhL1NRTFNlcnZlckpkYmNNZXRhZGF0YS5qYXZh)
| `100% <ø> (ø)` | `4 <0> (?)` | |
|
[...ain/java/org/apache/kylin/source/jdbc/SqlUtil.java](https://codecov.io/gh/apache/kylin/pull/312/diff?src=pr&el=tree#diff-c291cmNlLWpkYmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9qZGJjL1NxbFV0aWwuamF2YQ==)
| `13.69% <ø> (ø)` | `10 <0> (?)` | |
|
[.../org/apache/kylin/source/jdbc/JdbcHiveMRInput.java](https://codecov.io/gh/apache/kylin/pull/312/diff?src=pr&el=tree#diff-c291cmNlLWpkYmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9qZGJjL0pkYmNIaXZlTVJJbnB1dC5qYXZh)
| `8.24% <ø> (ø)` | `2 <0> (?)` | |
|
[.../org/apache/kylin/source/jdbc/JdbcTableReader.java](https://codecov.io/gh/apache/kylin/pull/312/diff?src=pr&el=tree#diff-c291cmNlLWpkYmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9qZGJjL0pkYmNUYWJsZVJlYWRlci5qYXZh)
| `0% <ø> (ø)` | `0 <0> (?)` | |
|
[.../java/org/apache/kylin/source/jdbc/JdbcSource.java](https://codecov.io/gh/apache/kylin/pull/312/diff?src=pr&el=tree#diff-c291cmNlLWpkYmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9qZGJjL0pkYmNTb3VyY2UuamF2YQ==)
| `0% <ø> (ø)` | `0 <0> (?)` | |
|
[...java/org/apache/kylin/source/jdbc/HiveCmdStep.java](https://codecov.io/gh/apache/kylin/pull/312/diff?src=pr&el=tree#diff-c291cmNlLWpkYmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9qZGJjL0hpdmVDbWRTdGVwLmphdmE=)
| `0% <ø> (ø)` | `0 <0> (?)` | |
|
[...ylin/source/jdbc/metadata/DefaultJdbcMetadata.java](https://codecov.io/gh/apache/kylin/pull/312/diff?src=pr&el=tree#diff-c291cmNlLWpkYmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9qZGJjL21ldGFkYXRhL0RlZmF1bHRKZGJjTWV0YWRhdGEuamF2YQ==)
| `100% <ø> (ø)` | `8 <0> (?)` | |
|
[...ylin/source/jdbc/metadata/JdbcMetadataFactory.java](https://codecov.io/gh/apache/kylin/pull/312/diff?src=pr&el=tree#diff-c291cmNlLWpkYmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9qZGJjL21ldGFkYXRhL0pkYmNNZXRhZGF0YUZhY3RvcnkuamF2YQ==)
| `50% <ø> (ø)` | `5 <0> (?)` | |
|
[...n/java/org/apache/kylin/source/jdbc/JdbcTable.java](https://codecov.io/gh/apache/kylin/pull/312/diff?src=pr&el=tree#diff-c291cmNlLWpkYmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9qZGJjL0pkYmNUYWJsZS5qYXZh)
| `0% <ø> (ø)` | `0 <0> (?)` | |
| ... and [79
more](https://codecov.io/gh/apache/kylin/pull/312/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/kylin/pull/312?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/kylin/pull/312?src=pr&el=footer). Last
update
[21bc42d...9f32219](https://codecov.io/gh/apache/kylin/pull/312?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Data Source SDK to ingest data from different JDBC sources
> ----------------------------------------------------------
>
> Key: KYLIN-3552
> URL: https://issues.apache.org/jira/browse/KYLIN-3552
> Project: Kylin
> Issue Type: New Feature
> Components: Query Engine, RDBMS Source
> Reporter: youcheng.zhang
> Assignee: youcheng.zhang
> Priority: Major
> Fix For: v2.6.0
>
>
> Kylin already supports JDBC source, but it takes much efforts to develop an
> implementation to a new source engine, like supporting metadata sync, cube
> build and query pushdown. It’s mainly because the SQL dialects and jdbc
> implementations between source engines are quite different.
> We propose to develop a data source sdk, which provides APIs to help
> developers handle these dialect differences and easily implement an adaptor
> for one source engine. With this SDK, users can achieve followings from a
> JDBC source:
> # synchronize metadata and data from jdbc source.
> # Build cube from jdbc source.
> # query pushdown to jdbc source engine when cube is unmatched.
> The SDK will define some interfaces of adaptors. To implement a new source,
> developers only need to implement an adaptor for the source.
> To keep compatibly, we will keep the existing JDBC source module, and
> implement a new JDBC source module as the caller of the SDK. Besides, we will
> also provide a pushdown implementation class as the caller of SDK for
> pushdown scenarios.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
