[
https://issues.apache.org/jira/browse/KYLIN-3649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668022#comment-16668022
]
Shaofeng SHI commented on KYLIN-3649:
-------------------------------------
Hi Lingang,
Cool, I'm merging the patch. Here are two comments:
1) I see you're removing the check for "hbase"; while Kylin is going to support
multiple storage engines, so similar check is needed. The right way is to check
whether CubeDesc.storageType == IStorageAware.ID_HBASE;
2) the patch couldn't be applied; please use "git format-patch -1" command to
generate a patch with your author info. You can follow the "Generate patch"
section in [https://kylin.apache.org/development/howto_contribute.html;]
Once you revise the patch, I will merge them. Thank you!
> segment region count and size are not correct when using mysql as Kylin
> metadata storage
> -----------------------------------------------------------------------------------------
>
> Key: KYLIN-3649
> URL: https://issues.apache.org/jira/browse/KYLIN-3649
> Project: Kylin
> Issue Type: Bug
> Components: Metadata
> Affects Versions: v2.5.0
> Reporter: Lingang Deng
> Assignee: Lingang Deng
> Priority: Major
> Fix For: v2.5.1
>
> Attachments: KYLIN-3649.patch
>
>
> As titles, segment region count and size are not correct.
> {code:java}
> if ("hbase".equals(getConfig().getMetadataUrl().getScheme())) {
> try {
> logger.debug("Loading HTable info " + cubeName + ", " + tableName);
> // use reflection to isolate NoClassDef errors when HBase is not
> available
> hr = (HBaseResponse)
> Class.forName("org.apache.kylin.rest.service.HBaseInfoUtil")//
> .getMethod("getHBaseInfo", new Class[] { String.class,
> KylinConfig.class })//
> .invoke(null, tableName, this.getConfig());
> } catch (Throwable e) {
> throw new IOException(e);
> }
> }
> {code}
> Judgement is not valid when using mysql as Kylin metadata storage.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
