[
https://issues.apache.org/jira/browse/KYLIN-3290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16692798#comment-16692798
]
ASF GitHub Bot commented on KYLIN-3290:
---------------------------------------
codecov-io commented on issue #351: KYLIN-3290 Leverage
getDecalredConstructor().newInstance() instead of newInstance()
URL: https://github.com/apache/kylin/pull/351#issuecomment-440175653
# [Codecov](https://codecov.io/gh/apache/kylin/pull/351?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base
(`master@dca3ee7`). [Click here to learn what that
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `50%`.
[](https://codecov.io/gh/apache/kylin/pull/351?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #351 +/- ##
=========================================
Coverage ? 23.61%
Complexity ? 4826
=========================================
Files ? 1133
Lines ? 68102
Branches ? 9659
=========================================
Hits ? 16080
Misses ? 50457
Partials ? 1565
```
| [Impacted
Files](https://codecov.io/gh/apache/kylin/pull/351?src=pr&el=tree) | Coverage Δ
| Complexity Δ | |
|---|---|---|---|
|
[...va/org/apache/kylin/dict/DictionarySerializer.java](https://codecov.io/gh/apache/kylin/pull/351/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L0RpY3Rpb25hcnlTZXJpYWxpemVyLmphdmE=)
| `0% <0%> (ø)` | `0 <0> (?)` | |
|
[...n/java/org/apache/kylin/dict/NumberDictionary.java](https://codecov.io/gh/apache/kylin/pull/351/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L051bWJlckRpY3Rpb25hcnkuamF2YQ==)
| `22.22% <0%> (ø)` | `2 <0> (?)` | |
|
[...g/apache/kylin/query/relnode/OLAPAggregateRel.java](https://codecov.io/gh/apache/kylin/pull/351/diff?src=pr&el=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L3JlbG5vZGUvT0xBUEFnZ3JlZ2F0ZVJlbC5qYXZh)
| `0% <0%> (ø)` | `0 <0> (?)` | |
|
[.../apache/kylin/dict/global/GlobalDictHDFSStore.java](https://codecov.io/gh/apache/kylin/pull/351/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2dsb2JhbC9HbG9iYWxEaWN0SERGU1N0b3JlLmphdmE=)
| `70.44% <100%> (ø)` | `18 <0> (?)` | |
|
[...n/java/org/apache/kylin/common/util/ClassUtil.java](https://codecov.io/gh/apache/kylin/pull/351/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi91dGlsL0NsYXNzVXRpbC5qYXZh)
| `51.66% <100%> (ø)` | `9 <1> (?)` | |
|
[...va/org/apache/kylin/dict/TrieDictionaryForest.java](https://codecov.io/gh/apache/kylin/pull/351/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L1RyaWVEaWN0aW9uYXJ5Rm9yZXN0LmphdmE=)
| `87.32% <100%> (ø)` | `62 <0> (?)` | |
|
[...ain/java/org/apache/kylin/dict/TrieDictionary.java](https://codecov.io/gh/apache/kylin/pull/351/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L1RyaWVEaWN0aW9uYXJ5LmphdmE=)
| `73.02% <100%> (ø)` | `57 <1> (?)` | |
|
[.../java/org/apache/kylin/dict/NumberDictionary2.java](https://codecov.io/gh/apache/kylin/pull/351/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L051bWJlckRpY3Rpb25hcnkyLmphdmE=)
| `71.42% <100%> (ø)` | `2 <0> (?)` | |
|
[...rg/apache/kylin/dict/DictionaryInfoSerializer.java](https://codecov.io/gh/apache/kylin/pull/351/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L0RpY3Rpb25hcnlJbmZvU2VyaWFsaXplci5qYXZh)
| `56.66% <20%> (ø)` | `5 <0> (?)` | |
|
[...n/java/org/apache/kylin/query/QueryConnection.java](https://codecov.io/gh/apache/kylin/pull/351/diff?src=pr&el=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L1F1ZXJ5Q29ubmVjdGlvbi5qYXZh)
| `83.33% <50%> (ø)` | `3 <0> (?)` | |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/kylin/pull/351?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/kylin/pull/351?src=pr&el=footer). Last
update
[dca3ee7...fe29b71](https://codecov.io/gh/apache/kylin/pull/351?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Avoid calling Class#newInstance
> -------------------------------
>
> Key: KYLIN-3290
> URL: https://issues.apache.org/jira/browse/KYLIN-3290
> Project: Kylin
> Issue Type: Task
> Reporter: Ted Yu
> Assignee: Wu Bin
> Priority: Minor
> Labels: jdk
> Fix For: v2.6.0
>
>
> Class#newInstance is deprecated starting in Java 9 -
> https://bugs.openjdk.java.net/browse/JDK-6850612 - because it may throw
> undeclared checked exceptions.
> The suggested replacement is getDeclaredConstructor().newInstance(), which
> wraps the checked exceptions in InvocationException.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
