[
https://issues.apache.org/jira/browse/KYLIN-3697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16693934#comment-16693934
]
ASF GitHub Bot commented on KYLIN-3697:
---------------------------------------
shaofengshi closed pull request #354: KYLIN-3697 minor, only kylin.sh start
check-env
URL: https://github.com/apache/kylin/pull/354
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/build/bin/kylin.sh b/build/bin/kylin.sh
index b65cb958a5..b04707815c 100755
--- a/build/bin/kylin.sh
+++ b/build/bin/kylin.sh
@@ -27,7 +27,6 @@ if [ "$verbose" = true ]; then
shift
fi
-source ${dir}/check-env.sh
mkdir -p ${KYLIN_HOME}/logs
mkdir -p ${KYLIN_HOME}/ext
@@ -66,7 +65,9 @@ then
quit "Kylin is running, stop it first"
fi
fi
-
+
+ source ${dir}/check-env.sh
+
tomcat_root=${dir}/../tomcat
export tomcat_root
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> check port availability when starts kylin instance
> --------------------------------------------------
>
> Key: KYLIN-3697
> URL: https://issues.apache.org/jira/browse/KYLIN-3697
> Project: Kylin
> Issue Type: Bug
> Affects Versions: v2.5.1
> Reporter: May Zhou
> Priority: Minor
>
> As I ran the script and it turned out with no error message, and I ran the
> kylin.sh start script, the console output indicated that a kylin instance had
> successfully started, but when I visit the <host>:<port>/kylin, I found
> another service was running rather than kylin.
>
> I can only find the error message in the kylin.out, which is not so
> user-friendly.
> > Caused by: java.net.BindException: Address already in use (Bind failed)
> at java.net.PlainSocketImpl.socketBind(Native Method)
> at
> java.net.AbstractPlainSocketImpl.bind(AbstractPlainSocketImpl.java:387)
> at java.net.ServerSocket.bind(ServerSocket.java:375)
> I am wondering why check-env does not check the availability of port, and the
> error message could be threw out more user-friendly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
