[
https://issues.apache.org/jira/browse/KYLIN-3665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696358#comment-16696358
]
ASF GitHub Bot commented on KYLIN-3665:
---------------------------------------
codecov-io commented on issue #356: KYLIN-3665 Partition time column may never
be used
URL: https://github.com/apache/kylin/pull/356#issuecomment-441150667
# [Codecov](https://codecov.io/gh/apache/kylin/pull/356?src=pr&el=h1) Report
> Merging [#356](https://codecov.io/gh/apache/kylin/pull/356?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/kylin/commit/98cb504470c85718abd1616e78d36851c21f2fd0?src=pr&el=desc)
will **decrease** coverage by `<.01%`.
> The diff coverage is `92.1%`.
[](https://codecov.io/gh/apache/kylin/pull/356?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #356 +/- ##
============================================
- Coverage 23.61% 23.61% -0.01%
- Complexity 4826 4830 +4
============================================
Files 1133 1133
Lines 68104 68093 -11
Branches 9659 9661 +2
============================================
- Hits 16085 16080 -5
+ Misses 50455 50448 -7
- Partials 1564 1565 +1
```
| [Impacted
Files](https://codecov.io/gh/apache/kylin/pull/356?src=pr&el=tree) | Coverage Δ
| Complexity Δ | |
|---|---|---|---|
|
[...org/apache/kylin/metadata/model/PartitionDesc.java](https://codecov.io/gh/apache/kylin/pull/356/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvbW9kZWwvUGFydGl0aW9uRGVzYy5qYXZh)
| `75% <92.1%> (+8.54%)` | `23 <3> (+5)` | :arrow_up: |
|
[...org/apache/kylin/rest/util/QueryRequestLimits.java](https://codecov.io/gh/apache/kylin/pull/356/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvdXRpbC9RdWVyeVJlcXVlc3RMaW1pdHMuamF2YQ==)
| `35.71% <0%> (-4.77%)` | `5% <0%> (-1%)` | |
|
[...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/356/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh)
| `69.3% <0%> (-1.83%)` | `7% <0%> (ø)` | |
|
[...g/apache/kylin/source/datagen/ColumnGenerator.java](https://codecov.io/gh/apache/kylin/pull/356/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc291cmNlL2RhdGFnZW4vQ29sdW1uR2VuZXJhdG9yLmphdmE=)
| `70.94% <0%> (-1.36%)` | `8% <0%> (ø)` | |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/kylin/pull/356?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/kylin/pull/356?src=pr&el=footer). Last
update
[98cb504...1a6d598](https://codecov.io/gh/apache/kylin/pull/356?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Partition time column may never be added
> ----------------------------------------
>
> Key: KYLIN-3665
> URL: https://issues.apache.org/jira/browse/KYLIN-3665
> Project: Kylin
> Issue Type: Bug
> Reporter: Chao Long
> Assignee: Chao Long
> Priority: Major
> Fix For: v2.6.0
>
>
> The partition time column will never be added to the WHERE clause if the
> partition date column is type of int or bigint and the date format is
> "yyyyMMdd", "yyyyMMddHH", "yyyyMMddHHmm" or "yyyyMMddHHmmss".
> Let’s say I have a fact table with two date partition column: day as the
> format of integer (yyyyMMdd) and minute as the format of string (HHmm). I
> have models created based on it and set the Partition Date Column to be “day”
> with the format of yyyyMMdd and the Partition Time Column to be “minute” with
> the format of HHmm. When I build the cube built on top of that model, I set
> the Start Date to be 2018-11-01 00:00:00 and the End Date to be 2018-11-01
> 01:00:00. The building process is supposed to retrieve the data from the fact
> table in the range of “day = 20181101 and minute>=’0000’ and minute<’0100’”.
> However, it retrieves the data in the range of “WHERE 1=1 AND (DAY >=
> 20181101 AND DAY < 20181101), so no data are actually retrieved.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
