[
https://issues.apache.org/jira/browse/KYLIN-3559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696492#comment-16696492
]
ASF GitHub Bot commented on KYLIN-3559:
---------------------------------------
coveralls commented on issue #358: KYLIN-3559 Use Splitter for splitting String
URL: https://github.com/apache/kylin/pull/358#issuecomment-441174625
## Pull Request Test Coverage Report for [Build
3878](https://coveralls.io/builds/20255839)
* **9** of **42** **(21.43%)** changed or added relevant lines in **21**
files are covered.
* **7** unchanged lines in **3** files lost coverage.
* Overall coverage increased (+**0.002%**) to **25.918%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
|
[core-cube/src/main/java/org/apache/kylin/cube/cli/CubeSignatureRefresher.java](https://coveralls.io/builds/20255839/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcli%2FCubeSignatureRefresher.java#L65)
| 0 | 1 | 0.0%
|
[core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DistributedScheduler.java](https://coveralls.io/builds/20255839/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fimpl%2Fthreadpool%2FDistributedScheduler.java#L154)
| 0 | 1 | 0.0%
|
[engine-mr/src/main/java/org/apache/kylin/engine/mr/common/AbstractHadoopJob.java](https://coveralls.io/builds/20255839/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fcommon%2FAbstractHadoopJob.java#L327)
| 0 | 1 | 0.0%
|
[engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/MergeDictionaryReducer.java](https://coveralls.io/builds/20255839/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fsteps%2FMergeDictionaryReducer.java#L39)
| 0 | 1 | 0.0%
|
[engine-spark/src/main/java/org/apache/kylin/engine/spark/SparkMergingDictionary.java](https://coveralls.io/builds/20255839/source?filename=engine-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fspark%2FSparkMergingDictionary.java#L155)
| 0 | 1 | 0.0%
|
[query/src/main/java/org/apache/kylin/query/relnode/OLAPTableScan.java](https://coveralls.io/builds/20255839/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Frelnode%2FOLAPTableScan.java#L246)
| 0 | 1 | 0.0%
|
[server-base/src/main/java/org/apache/kylin/rest/init/InitialTaskManager.java](https://coveralls.io/builds/20255839/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Finit%2FInitialTaskManager.java#L53)
| 0 | 1 | 0.0%
|
[server-base/src/main/java/org/apache/kylin/rest/service/AdminService.java](https://coveralls.io/builds/20255839/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FAdminService.java#L110)
| 0 | 1 | 0.0%
|
[server-base/src/main/java/org/apache/kylin/rest/service/QueryService.java](https://coveralls.io/builds/20255839/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FQueryService.java#L319)
| 0 | 1 | 0.0%
|
[source-hive/src/main/java/org/apache/kylin/source/hive/cardinality/HiveColumnCardinalityUpdateJob.java](https://coveralls.io/builds/20255839/source?filename=source-hive%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fhive%2Fcardinality%2FHiveColumnCardinalityUpdateJob.java#L164)
| 0 | 1 | 0.0%
<!-- | **Total:** | **9** | **42** | **21.43%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
|
[engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/MergeDictionaryMapper.java](https://coveralls.io/builds/20255839/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fsteps%2FMergeDictionaryMapper.java#L126)
| 1 | 0.0% |
|
[server-base/src/main/java/org/apache/kylin/rest/util/QueryRequestLimits.java](https://coveralls.io/builds/20255839/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Futil%2FQueryRequestLimits.java#L72)
| 1 | 47.62% |
|
[core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/20255839/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439)
| 5 | 77.81% |
<!-- | **Total:** | **7** | | -->
| Totals | [](https://coveralls.io/builds/20255839)
|
| :-- | --: |
| Change from base [Build 3871](https://coveralls.io/builds/20236865): |
0.002% |
| Covered Lines: | 17651 |
| Relevant Lines: | 68102 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Use Splitter for splitting String
> ---------------------------------
>
> Key: KYLIN-3559
> URL: https://issues.apache.org/jira/browse/KYLIN-3559
> Project: Kylin
> Issue Type: Task
> Reporter: Ted Yu
> Assignee: Wu Bin
> Priority: Major
> Fix For: v2.6.0
>
>
> See http://errorprone.info/bugpattern/StringSplitter for why Splitter is
> preferred .
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
