shaofengshi commented on a change in pull request #359: KYLIN-3628 The wrong
result when a query with one lookup table
URL: https://github.com/apache/kylin/pull/359#discussion_r239672931
##########
File path: core-cube/src/main/java/org/apache/kylin/cube/CubeInstance.java
##########
@@ -717,4 +724,51 @@ public static CubeSegment findSegmentWithJobId(String
jobID, CubeInstance cubeIn
throw new IllegalStateException("No segment's last build job ID equals
" + jobID);
}
+ public CubeInstance findLastSnapshot(List<RealizationEntry>
realizationEntries, String lookupTableName) {
Review comment:
CubeInstance is not the best place to put such a method. Please move it to
CubeManager.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
