[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues

Thu, 06 Dec 2018 18:46:14 -0800 


    [ 
https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16712276#comment-16712276
 ] 

ASF GitHub Bot commented on KYLIN-3597:
---------------------------------------

codecov-io edited a comment on issue #374: KYLIN-3597 Improve code smell
URL: https://github.com/apache/kylin/pull/374#issuecomment-445096812
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/374?src=pr&el=h1) Report
   > Merging [#374](https://codecov.io/gh/apache/kylin/pull/374?src=pr&el=desc) 
into 
[master](https://codecov.io/gh/apache/kylin/commit/2979f4092ee338ad1bbdaeaca5639d99466268d8?src=pr&el=desc)
 will **decrease** coverage by `<.01%`.
   > The diff coverage is `7.14%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/kylin/pull/374/graphs/tree.svg?width=650&token=JawVgbgsVo&height=150&src=pr)](https://codecov.io/gh/apache/kylin/pull/374?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #374      +/-   ##
   ============================================
   - Coverage     23.63%   23.63%   -0.01%     
     Complexity     4839     4839              
   ============================================
     Files          1131     1131              
     Lines         68201    68207       +6     
     Branches       9685     9688       +3     
   ============================================
   - Hits          16122    16119       -3     
   - Misses        50511    50519       +8     
   - Partials       1568     1569       +1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/kylin/pull/374?src=pr&el=tree) | Coverage Δ 
| Complexity Δ | |
   |---|---|---|---|
   | 
[...ylin/query/relnode/visitor/TupleFilterVisitor.java](https://codecov.io/gh/apache/kylin/pull/374/diff?src=pr&el=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L3JlbG5vZGUvdmlzaXRvci9UdXBsZUZpbHRlclZpc2l0b3IuamF2YQ==)
 | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | 
[.../apache/kylin/cube/cli/DictionaryGeneratorCLI.java](https://codecov.io/gh/apache/kylin/pull/374/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2NsaS9EaWN0aW9uYXJ5R2VuZXJhdG9yQ0xJLmphdmE=)
 | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | 
[...pache/kylin/cube/inmemcubing/InMemCubeBuilder.java](https://codecov.io/gh/apache/kylin/pull/374/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL0luTWVtQ3ViZUJ1aWxkZXIuamF2YQ==)
 | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | 
[...ache/kylin/cube/inmemcubing/DoggedCubeBuilder.java](https://codecov.io/gh/apache/kylin/pull/374/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL0RvZ2dlZEN1YmVCdWlsZGVyLmphdmE=)
 | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | 
[...in/java/org/apache/kylin/cube/CubeDescManager.java](https://codecov.io/gh/apache/kylin/pull/374/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL0N1YmVEZXNjTWFuYWdlci5qYXZh)
 | `33.81% <44.44%> (ø)` | `12 <0> (ø)` | :arrow_down: |
   | 
[.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/374/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=)
 | `63.84% <0%> (-2.31%)` | `0% <0%> (ø)` | |
   | 
[...g/apache/kylin/source/datagen/ColumnGenerator.java](https://codecov.io/gh/apache/kylin/pull/374/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc291cmNlL2RhdGFnZW4vQ29sdW1uR2VuZXJhdG9yLmphdmE=)
 | `70.94% <0%> (-1.36%)` | `8% <0%> (ø)` | |
   | 
[...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/374/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh)
 | `70.21% <0%> (+0.6%)` | `7% <0%> (ø)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/kylin/pull/374?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/kylin/pull/374?src=pr&el=footer). Last 
update 
[2979f40...798df64](https://codecov.io/gh/apache/kylin/pull/374?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Fix sonar reported static code issues
> -------------------------------------
>
>                 Key: KYLIN-3597
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3597
>             Project: Kylin
>          Issue Type: Improvement
>          Components: Others
>            Reporter: Shaofeng SHI
>            Priority: Major
>             Fix For: v2.6.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to