[
https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16714519#comment-16714519
] ASF GitHub Bot commented on KYLIN-3597: --------------------------------------- codecov-io commented on issue #378: KYLIN-3597 Improve code smell URL: https://github.com/apache/kylin/pull/378#issuecomment-445759183 # [Codecov](https://codecov.io/gh/apache/kylin/pull/378?src=pr&el=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@684f21c`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `9.8%`. [](https://codecov.io/gh/apache/kylin/pull/378?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #378 +/- ## ========================================= Coverage ? 23.63% Complexity ? 4881 ========================================= Files ? 1134 Lines ? 68648 Branches ? 9749 ========================================= Hits ? 16225 Misses ? 50834 Partials ? 1589 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/378?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...kylin/measure/percentile/PercentileSerializer.java](https://codecov.io/gh/apache/kylin/pull/378/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWVhc3VyZS9wZXJjZW50aWxlL1BlcmNlbnRpbGVTZXJpYWxpemVyLmphdmE=) | `75% <ø> (ø)` | `5 <0> (?)` | | | [...apache/kylin/storage/hbase/util/RowCounterCLI.java](https://codecov.io/gh/apache/kylin/pull/378/diff?src=pr&el=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS91dGlsL1Jvd0NvdW50ZXJDTEkuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...e/kylin/source/kafka/util/KafkaSampleProducer.java](https://codecov.io/gh/apache/kylin/pull/378/diff?src=pr&el=tree#diff-c291cmNlLWthZmthL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9zb3VyY2Uva2Fma2EvdXRpbC9LYWZrYVNhbXBsZVByb2R1Y2VyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...ylin/query/relnode/visitor/TupleFilterVisitor.java](https://codecov.io/gh/apache/kylin/pull/378/diff?src=pr&el=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L3JlbG5vZGUvdmlzaXRvci9UdXBsZUZpbHRlclZpc2l0b3IuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...ache/kylin/cube/inmemcubing/DoggedCubeBuilder.java](https://codecov.io/gh/apache/kylin/pull/378/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL0RvZ2dlZEN1YmVCdWlsZGVyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...pache/kylin/cube/inmemcubing/InMemCubeBuilder.java](https://codecov.io/gh/apache/kylin/pull/378/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL0luTWVtQ3ViZUJ1aWxkZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | | | [.../apache/kylin/cube/cli/DictionaryGeneratorCLI.java](https://codecov.io/gh/apache/kylin/pull/378/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2NsaS9EaWN0aW9uYXJ5R2VuZXJhdG9yQ0xJLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...in/java/org/apache/kylin/query/util/QueryUtil.java](https://codecov.io/gh/apache/kylin/pull/378/diff?src=pr&el=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L3V0aWwvUXVlcnlVdGlsLmphdmE=) | `58.97% <25%> (ø)` | `19 <0> (?)` | | | [...in/java/org/apache/kylin/cube/CubeDescManager.java](https://codecov.io/gh/apache/kylin/pull/378/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL0N1YmVEZXNjTWFuYWdlci5qYXZh) | `33.81% <57.14%> (ø)` | `12 <0> (?)` | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/378?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/378?src=pr&el=footer). Last update [684f21c...74ef7e8](https://codecov.io/gh/apache/kylin/pull/378?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] > Fix sonar reported static code issues > ------------------------------------- > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others > Reporter: Shaofeng SHI > Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
