shaofengshi commented on a change in pull request #398: Kylin 3597 fix sonar
issues
URL: https://github.com/apache/kylin/pull/398#discussion_r243737662
##########
File path:
core-cube/src/main/java/org/apache/kylin/cube/inmemcubing2/InMemCubeBuilder2.java
##########
@@ -295,29 +295,30 @@ private void makeMemoryBudget() {
GTScanRequest req = new
GTScanRequestBuilder().setInfo(baseCuboid.getInfo()).setRanges(null).setDimensions(null)
.setAggrGroupBy(dimensionMetricsBitSet.getFirst()).setAggrMetrics(dimensionMetricsBitSet.getSecond())
.setAggrMetricsFuncs(metricsAggrFuncs).setFilterPushDown(null).createGTScanRequest();
- GTAggregateScanner aggregationScanner = new
GTAggregateScanner(baseInput, req);
- aggregationScanner.trackMemoryLevel(baseCuboidMemTracker);
+ try (GTAggregateScanner aggregationScanner = new
GTAggregateScanner(baseInput, req)) {
+ aggregationScanner.trackMemoryLevel(baseCuboidMemTracker);
- int count = 0;
- for (GTRecord r : aggregationScanner) {
- if (count == 0) {
- baseCuboidMemTracker.markHigh();
+ int count = 0;
+ for (GTRecord r : aggregationScanner) {
+ if (count == 0) {
+ baseCuboidMemTracker.markHigh();
+ }
+ baseBuilder.write(r);
+ count++;
}
- baseBuilder.write(r);
- count++;
- }
- aggregationScanner.close();
- baseBuilder.close();
- sw.stop();
- logger.info("Cuboid " + baseCuboidId + " has " + count + " rows, build
takes " + sw.elapsedMillis() + "ms");
+ baseBuilder.close();
+
+ sw.stop();
+ logger.info("Cuboid " + baseCuboidId + " has " + count + " rows,
build takes " + sw.elapsedMillis() + "ms");
- int mbEstimateBaseAggrCache = (int)
(aggregationScanner.getEstimateSizeOfAggrCache()
- / MemoryBudgetController.ONE_MB);
- logger.info("Wild estimate of base aggr cache is " +
mbEstimateBaseAggrCache + " MB");
+ int mbEstimateBaseAggrCache = (int)
(aggregationScanner.getEstimateSizeOfAggrCache()
+ / MemoryBudgetController.ONE_MB);
+ logger.info("Wild estimate of base aggr cache is " +
mbEstimateBaseAggrCache + " MB");
Review comment:
We can use the "{}" to format the log output.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
