shaofengshi commented on a change in pull request #409: KYLIN-2972 CacheKey
from SQLRequest should ignore the case of project…
URL: https://github.com/apache/kylin/pull/409#discussion_r243750309
##########
File path:
server-base/src/main/java/org/apache/kylin/rest/request/SQLRequest.java
##########
@@ -105,7 +105,7 @@ public Object getCacheKey() {
return cacheKey;
cacheKey = Lists.newArrayList(sql.replaceAll("[ ]", " ") //
- , project //
+ , getNormProject() //
Review comment:
Can we normalize the value to upper case when the request is received? Then
downstream doesn't need to handle the case each time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
