codecov-io edited a comment on issue #359: KYLIN-3628 The wrong result when a query with one lookup table URL: https://github.com/apache/kylin/pull/359#issuecomment-445522483 # [Codecov](https://codecov.io/gh/apache/kylin/pull/359?src=pr&el=h1) Report > Merging [#359](https://codecov.io/gh/apache/kylin/pull/359?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/1af62e46516b7b9a31d3de5a1a7867f9cb51799b?src=pr&el=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/kylin/pull/359?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #359 +/- ## ============================================ - Coverage 24.39% 24.38% -0.02% + Complexity 4935 4934 -1 ============================================ Files 1143 1143 Lines 69259 69282 +23 Branches 9859 9865 +6 ============================================ - Hits 16897 16893 -4 - Misses 50665 50690 +25 - Partials 1697 1699 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/359?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../main/java/org/apache/kylin/cube/CubeInstance.java](https://codecov.io/gh/apache/kylin/pull/359/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL0N1YmVJbnN0YW5jZS5qYXZh) | `37.9% <ø> (ø)` | `50 <0> (ø)` | :arrow_down: | | [...c/main/java/org/apache/kylin/cube/CubeManager.java](https://codecov.io/gh/apache/kylin/pull/359/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL0N1YmVNYW5hZ2VyLmphdmE=) | `38.15% <0%> (-1.13%)` | `44 <0> (ø)` | | | [.../kylin/query/enumerator/LookupTableEnumerator.java](https://codecov.io/gh/apache/kylin/pull/359/diff?src=pr&el=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L2VudW1lcmF0b3IvTG9va3VwVGFibGVFbnVtZXJhdG9yLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/359/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==) | `72.97% <0%> (-5.41%)` | `6% <0%> (-1%)` | | | [...g/apache/kylin/source/datagen/ColumnGenerator.java](https://codecov.io/gh/apache/kylin/pull/359/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc291cmNlL2RhdGFnZW4vQ29sdW1uR2VuZXJhdG9yLmphdmE=) | `70.94% <0%> (-1.36%)` | `8% <0%> (ø)` | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/359?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/359?src=pr&el=footer). Last update [1af62e4...3e6fc39](https://codecov.io/gh/apache/kylin/pull/359?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
