[ 
https://issues.apache.org/jira/browse/KYLIN-3770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16743584#comment-16743584
 ] 

Chao Long commented on KYLIN-3770:
----------------------------------

Hi Temple, I run unzip command in my computer and I get dir structure:
{quote}➜ resources git:(test) ✗ unzip cloned_cube_meta.zip
Archive: cloned_cube_meta.zip
 creating: cloned_cube_meta/
 inflating: cloned_cube_meta/commit_SHA1
 creating: cloned_cube_meta/cube/
 inflating: cloned_cube_meta/cube/cloned_cube.json
 creating: cloned_cube_meta/cube_desc/
 inflating: cloned_cube_meta/cube_desc/cloned_cube.json
 extracting: cloned_cube_meta/info
 inflating: cloned_cube_meta/kylin_env
 creating: cloned_cube_meta/model_desc/
 inflating: cloned_cube_meta/model_desc/test_kylin_inner_join_model_desc.json
 creating: cloned_cube_meta/table/
 inflating: cloned_cube_meta/table/DEFAULT.TEST_CATEGORY_GROUPINGS.json
 inflating: cloned_cube_meta/table/DEFAULT.TEST_KYLIN_FACT.json
 inflating: cloned_cube_meta/table/EDW.TEST_CAL_DT.json
 inflating: cloned_cube_meta/table/EDW.TEST_SELLER_TYPE_DIM.json
 inflating: cloned_cube_meta/table/EDW.TEST_SITES.json
 creating: cloned_cube_meta/table_exd/
 inflating: cloned_cube_meta/table_exd/DEFAULT.TEST_KYLIN_FACT.json
 inflating: cloned_cube_meta/table_exd/EDW.TEST_CAL_DT.json
{quote}
And I think UT CubeMetaIngesterTest.java has covered the unzip case, maybe 
there is something wrong with the source zip file.

> ZipFileUtils is not compatible CubeMetaIngester
> -----------------------------------------------
>
>                 Key: KYLIN-3770
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3770
>             Project: Kylin
>          Issue Type: Bug
>          Components: Tools, Build and Test
>    Affects Versions: v2.3.0, v2.4.0, v2.5.0, v2.6.0
>            Reporter: Temple Zhou
>            Assignee: Temple Zhou
>            Priority: Major
>         Attachments: KYLIN-3770.master.001.patch
>
>
> KYLIN-3401 had changed the zip compress tool, so the unzip dir structure is 
> as follows:
> {code:bash}
> unzip base_2019_01_15_17_45_28.zip 
> Archive:  base_2019_01_15_17_45_28.zip
>   inflating: kylin_env               
>    creating: cube/
>   inflating: cube/test_global_dict1.json  
>   inflating: info                    
>    creating: table/
>   inflating: table/DEFAULT.TEST_GLOBAL_DICT1--tianpeng.json  
>    creating: table_exd/
>   inflating: table_exd/DEFAULT.TEST_GLOBAL_DICT1--tianpeng.json  
>   inflating: commit_SHA1             
>    creating: cube_statistics/
>    creating: cube_statistics/test_global_dict1/
>   inflating: 
> cube_statistics/test_global_dict1/24e4967f-f635-440f-82e8-d73f7cbb2f2d.seq  
>   inflating: 
> cube_statistics/test_global_dict1/adfb447f-4369-4dd8-9d76-94bc7f91d278.seq  
>    creating: model_desc/
>   inflating: model_desc/test_global_dict1.json  
>   inflating: UUID                    
>    creating: cube_desc/
>   inflating: cube_desc/test_global_dict1.json  
> {code}
> However, before the changing of KYLIN-3401, the unzip dir structure is :
> {code:bash}
> unzip base_2019_01_15_18_18_26.zip 
> Archive:  base_2019_01_15_18_18_26.zip
>   inflating: base_2019_01_15_18_18_26/kylin_env  
>   inflating: base_2019_01_15_18_18_26/cube/test_global_dict1.json  
>   inflating: base_2019_01_15_18_18_26/info  
>   inflating: 
> base_2019_01_15_18_18_26/table/DEFAULT.TEST_GLOBAL_DICT1--tianpeng.json  
>   inflating: 
> base_2019_01_15_18_18_26/table_exd/DEFAULT.TEST_GLOBAL_DICT1--tianpeng.json  
>   inflating: base_2019_01_15_18_18_26/commit_SHA1  
>   inflating: 
> base_2019_01_15_18_18_26/cube_statistics/test_global_dict1/24e4967f-f635-440f-82e8-d73f7cbb2f2d.seq
>   
>   inflating: 
> base_2019_01_15_18_18_26/cube_statistics/test_global_dict1/adfb447f-4369-4dd8-9d76-94bc7f91d278.seq
>   
>   inflating: base_2019_01_15_18_18_26/model_desc/test_global_dict1.json  
>   inflating: base_2019_01_15_18_18_26/UUID  
>   inflating: base_2019_01_15_18_18_26/cube_desc/test_global_dict1.json  
> {code}
> This modification led to the CubeMetaIngester will always throw the 
> IllegalStateException, as the tempFolder.list().length will never be 1.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to