allenma commented on a change in pull request #481: KYLIN-3821 Add consume lag stats URL: https://github.com/apache/kylin/pull/481#discussion_r260695771
########## File path: stream-core/src/main/java/org/apache/kylin/stream/core/consumer/IStreamingConnector.java ########## @@ -1,46 +1,55 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one - * or more contributor license agreements. See the NOTICE file - * distributed with this work for additional information - * regarding copyright ownership. The ASF licenses this file - * to you under the Apache License, Version 2.0 (the - * "License"); you may not use this file except in compliance - * with the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. -*/ - -package org.apache.kylin.stream.core.consumer; - -import java.util.List; - -import org.apache.kylin.stream.core.model.StreamingMessage; -import org.apache.kylin.stream.core.source.Partition; - -/** - * the streaming connector is used to connect to streaming source - */ -public interface IStreamingConnector { - void open(); - - void close(); - - /** - * wake up the connector if the connector is blocked - */ - void wakeup(); - - List<Partition> getConsumePartitions(); - - /** - * get next event - * @return - */ - StreamingMessage nextEvent(); -} +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. +*/ + +package org.apache.kylin.stream.core.consumer; + +import java.util.List; +import java.util.Map; + +import org.apache.kylin.stream.core.model.StreamingMessage; +import org.apache.kylin.stream.core.source.Partition; + +/** + * the streaming connector is used to connect to streaming source + */ +public interface IStreamingConnector { + void open(); + + void close(); + + /** + * wake up the connector if the connector is blocked + */ + void wakeup(); + + List<Partition> getConsumePartitions(); + + /** + * get next event + * @return + */ + StreamingMessage nextEvent(); + + /** + * Fetch the consume lag of each partition which own by current receiver + * consume lag is the difference between the latest event's offset and current cosuming event's offset + * + * @return a Map which key is the id of topic partition and value is the consume lag + */ + Map<Integer, Long> consumeLag(); Review comment: It is better to add a method: getLatestPosition(), and calculate the lag in the consumer side. Not sure we need return the ISourcePosition interface or not, currently the position abstraction is not very good. And why the code diff is replace the whole original file rather than add a new method? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
