shaofengshi commented on a change in pull request #507: KYLIN-3857 Disable
quote when needed
URL: https://github.com/apache/kylin/pull/507#discussion_r264630189
##########
File path:
core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java
##########
@@ -982,6 +982,14 @@ public int getDefaultDecimalScale() {
}
}
+ public boolean enableHiveDdlQuote(){
+ return
Boolean.parseBoolean(getOptional("kylin.source.hive.enable.quote", TRUE));
Review comment:
Please follow the config naming convension,
"kylin.source.hive.quote-enabled" is a better name, like
"kylin.engine.spark.sanity-check-enabled"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
