shaofengshi commented on a change in pull request #528: KYLIN-3883 Kylin
supports column count aggregation
URL: https://github.com/apache/kylin/pull/528#discussion_r268026818
##########
File path:
core-metadata/src/main/java/org/apache/kylin/metadata/model/FunctionDesc.java
##########
@@ -146,7 +146,11 @@ public boolean needRewriteField() {
public String getRewriteFieldName() {
if (isCount()) {
- return "_KY_" + "COUNT__"; // ignores parameter, count(*),
count(1), count(col) are all the same
+ if (parameter == null || parameter.getType().equals("constant")) {
Review comment:
Use "org.apache.kylin.metadata.model.ParameterDesc#isColumnType" method will
be more clear.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
